feat: Add styling to TOC #1014
Merged
feat: Add styling to TOC #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dcramer
commented
May 24, 2019
src/_js/lib/TableOfContents.js
Outdated
| let curMatch; | ||
| $(':header').each(function() { | ||
| const id = $(this).attr('id'); | ||
| if (id && scrollTop >= $(this).position().top) { |
There was a problem hiding this comment.
had to use .position instead of .offset since the scrollbar is not on document (but instead on .main-scroll)
dcramer
force-pushed
the
feat/toc-styles
branch
3 times, most recently
from
c21a006 to
525304f
Compare
evanpurkhiser
approved these changes
May 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.