-
-
Notifications
You must be signed in to change notification settings - Fork 5
test(deps): Bump the test-dependencies group with 15 updates #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| { | ||
| // To update the version of Uno please update the version of the Uno.Sdk here. See https://aka.platform.uno/upgrade-uno-packages for more information. | ||
| "msbuild-sdks": { | ||
| "Uno.Sdk": "6.5.31" | ||
| "Uno.Sdk": "6.5.33" | ||
| }, | ||
| "sdk": { | ||
| "version": "10.0.100", | ||
| "allowPrerelease": false, | ||
| "rollForward": "latestFeature" | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary Newtonsoft.Json dependency added to production project
Medium Severity
A
Newtonsoft.JsonPackageReferencewas added to the main application projectSentry.CrashReporter.csproj, but no code in this project uses Newtonsoft.Json — the project exclusively usesSystem.Text.Json. This adds an unnecessary runtime dependency to production code. The package was likely intended only for test projects (it already existed inSentry.CrashReporter.UITests.csproj). The PR is scoped to test dependencies, making this addition appear accidental. The inconsistent indentation (4 spaces vs 8 spaces for surrounding lines) further suggests this was unintentionally included.Reviewed by Cursor Bugbot for commit 926511d. Configure here.