Skip to content

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jun 24, 2022

📜 Description

Filter out app starts with more than 60s

💡 Motivation and Context

getsentry/sentry-cocoa#1899

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto requested a review from brustolin as a code owner June 24, 2022 07:10
@marandaneto marandaneto requested a review from bruno-garcia June 24, 2022 07:11
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.77%. Comparing base (1f0b11b) to head (6625b48).
⚠️ Report is 1467 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #895   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files         104      104           
  Lines        3207     3207           
=======================================
  Hits         2879     2879           
  Misses        328      328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto enabled auto-merge (squash) June 24, 2022 07:33
@marandaneto marandaneto merged commit 3bfd365 into main Jun 24, 2022
@marandaneto marandaneto deleted the fix/appstart-60s branch June 24, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants