Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
- Bump Native SDK from v0.12.6 to v0.12.8 ([#3514](https://github.com/getsentry/sentry-dart/pull/3514), [#3520](https://github.com/getsentry/sentry-dart/pull/3520))
- [changelog](https://github.com/getsentry/sentry-native/blob/master/CHANGELOG.md#0128)
- [diff](https://github.com/getsentry/sentry-native/compare/0.12.6...0.12.8)
- Bump Android SDK from v8.32.0 to v8.33.0 ([#3529](https://github.com/getsentry/sentry-dart/pull/3529))
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#8330)
- [diff](https://github.com/getsentry/sentry-java/compare/8.32.0...8.33.0)

## 9.13.0

Expand Down
4 changes: 2 additions & 2 deletions packages/flutter/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ android {
}

dependencies {
api 'io.sentry:sentry-android:8.32.0'
debugImplementation 'io.sentry:sentry-spotlight:8.32.0'
api 'io.sentry:sentry-android:8.33.0'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream PII behavioral change bypasses sendDefaultPii gate

Medium Severity

The upstream Android SDK 8.33.0 changelog includes "Attach user attributes to logs and metrics regardless of sendDefaultPii." This is a behavioral change where user-identifiable attributes are now sent even when sendDefaultPii is false. The review rules require PII to be gated behind the sendDefaultPii flag and require flagging behavioral changes in dependency updates that could affect existing integrations. This change could affect privacy expectations for users who have intentionally left sendDefaultPii disabled.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot (Root)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont use logs in native so this is fine.

debugImplementation 'io.sentry:sentry-spotlight:8.33.0'
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"

// Required -- JUnit 4 framework
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ class _AndroidReplayHandler extends WorkerHandler {

// https://developer.android.com/reference/android/graphics/Bitmap#createBitmap(int,%20int,%20android.graphics.Bitmap.Config)
// Note: while the generated API is nullable, the docs say the returned value cannot be null..
_bitmap ??= native.Bitmap.createBitmap$3(
_bitmap ??= native.Bitmap.createBitmap$10(
item.width, item.height, native.Bitmap$Config.ARGB_8888);

jBuffer = JByteBuffer.fromList(item.data);
Expand Down
Loading
Loading