Skip to content

Safely access browser navigator.deviceMemory #3268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 23, 2025
Merged

Safely access browser navigator.deviceMemory #3268

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7bbbaaf
Fix accessing deviec memory for non-supported browsers
denrase Sep 23, 2025
deaf5ce
update
denrase Sep 23, 2025
28313fd
Merge branch 'main' into fix/type-error-null
denrase Sep 23, 2025
506f66d
add changelog
denrase Sep 23, 2025
0656669
add test
denrase Sep 23, 2025
b62a943
format
denrase Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@

- Prefix firebase remote config feature flags with `firebase:` ([#3258](https://github.com/getsentry/sentry-dart/pull/3258))

### Fixes

- Safely access browser `navigator.deviceMemory` ([#3268](https://github.com/getsentry/sentry-dart/pull/3268))

## 9.7.0-beta.5

### Dependencies
Expand Down
18 changes: 13 additions & 5 deletions packages/dart/lib/src/event_processor/enricher/web_enricher_event_processor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import 'package:web/web.dart' as web show window, Window, Navigator;
import 'dart:js_interop';

import '../../../sentry.dart';
import 'enricher_event_processor.dart';
Expand Down Expand Up @@ -69,8 +70,7 @@ class WebEnricherEventProcessor implements EnricherEventProcessor {

int? _getMemorySize() {
// https://developer.mozilla.org/en-US/docs/Web/API/Navigator/deviceMemory
// ignore: invalid_null_aware_operator
final size = _window.navigator.deviceMemory?.toDouble();
final size = _window.navigator.safeDeviceMemory?.toDouble();
final memoryByteSize = size != null ? size * 1024 * 1024 * 1024 : null;
return memoryByteSize?.toInt();
}
Expand Down Expand Up @@ -116,7 +116,15 @@ class WebEnricherEventProcessor implements EnricherEventProcessor {
}
}

extension on web.Navigator {
// ignore: unused_element
external double? get deviceMemory;
/// Some Navigator properties are not fully supported in all browsers.
/// However, package:web does not provide a safe way to access these properties,
/// and assumes they are always not null.
///
/// This extension provides a safe way to access these properties.
///
/// See: https://github.com/dart-lang/web/issues/326
/// https://github.com/fluttercommunity/plus_plugins/issues/3391
extension SafeNavigationGetterExtensions on web.Navigator {
@JS('deviceMemory')
external double? get safeDeviceMemory;
}
Loading