Skip to content

Conversation

@denrase
Copy link
Collaborator

@denrase denrase commented Aug 28, 2025

📜 Description

The APIs which we use are stable for firebase_remote_config version 6.0.0. So I expanded the supported versions.

💡 Motivation and Context

Should fix CI checks: https://github.com/getsentry/sentry-dart/runs/49078490561

💚 How did you test it?

CI

@denrase denrase changed the title Support firebase_remote_config < 7.0.0 Support firebase_remote_config >=5.4.3 <7.0.0 Aug 28, 2025
@denrase denrase changed the title Support firebase_remote_config >=5.4.3 <7.0.0 Support firebase_remote_config: >=5.4.3 <7.0.0 Aug 28, 2025
@denrase denrase marked this pull request as ready for review August 28, 2025 09:46
@github-actions
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 443.26 ms 463.59 ms 20.33 ms
Size 13.93 MiB 14.93 MiB 1.00 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0929dbf 462.82 ms 492.76 ms 29.94 ms
ec78888 457.94 ms 519.96 ms 62.02 ms
de377fd 572.35 ms 589.21 ms 16.87 ms
5b9a0da 446.94 ms 449.22 ms 2.28 ms
765aa8b 493.51 ms 531.23 ms 37.72 ms
3615e19 468.38 ms 504.71 ms 36.33 ms
8825ed8 447.65 ms 456.90 ms 9.25 ms
0fb45d0 482.79 ms 554.02 ms 71.23 ms
dbd526b 504.88 ms 569.02 ms 64.15 ms
f761369 462.73 ms 563.80 ms 101.06 ms

App size

Revision Plain With Sentry Diff
0929dbf 6.54 MiB 7.70 MiB 1.17 MiB
ec78888 6.54 MiB 7.69 MiB 1.15 MiB
de377fd 6.54 MiB 7.71 MiB 1.17 MiB
5b9a0da 13.93 MiB 14.93 MiB 1.00 MiB
765aa8b 6.54 MiB 7.70 MiB 1.16 MiB
3615e19 6.54 MiB 7.70 MiB 1.16 MiB
8825ed8 13.93 MiB 14.93 MiB 1.00 MiB
0fb45d0 6.54 MiB 7.70 MiB 1.17 MiB
dbd526b 6.54 MiB 7.69 MiB 1.15 MiB
f761369 6.54 MiB 7.70 MiB 1.16 MiB

@github-actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1253.38 ms 1258.34 ms 4.97 ms
Size 5.53 MiB 5.97 MiB 453.77 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
81f83eb 1259.53 ms 1273.39 ms 13.86 ms
93b7728 1247.23 ms 1264.87 ms 17.64 ms
827bf09 1261.86 ms 1276.41 ms 14.55 ms
eca355d 1238.39 ms 1266.98 ms 28.59 ms
79f6b41 1269.33 ms 1279.71 ms 10.38 ms
dbd526b 1244.78 ms 1259.02 ms 14.24 ms
73dca78 1246.65 ms 1265.42 ms 18.76 ms
c26ed0a 1244.11 ms 1263.85 ms 19.75 ms
cc4e375 1253.06 ms 1263.81 ms 10.75 ms
b6c8720 1252.65 ms 1266.61 ms 13.96 ms

App size

Revision Plain With Sentry Diff
81f83eb 7.86 MiB 9.44 MiB 1.58 MiB
93b7728 7.86 MiB 9.44 MiB 1.58 MiB
827bf09 7.86 MiB 9.44 MiB 1.58 MiB
eca355d 7.86 MiB 9.44 MiB 1.58 MiB
79f6b41 7.86 MiB 9.44 MiB 1.58 MiB
dbd526b 7.86 MiB 9.44 MiB 1.58 MiB
73dca78 7.86 MiB 9.44 MiB 1.58 MiB
c26ed0a 5.53 MiB 5.97 MiB 453.76 KiB
cc4e375 7.86 MiB 9.44 MiB 1.58 MiB
b6c8720 7.86 MiB 9.44 MiB 1.58 MiB

@denrase denrase merged commit 7169a96 into main Aug 28, 2025
20 checks passed
@denrase denrase deleted the fix/firebase-remote-config-6 branch August 28, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants