Skip to content

enh: remove async from FlutterErrorIntegration #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2025
Merged

enh: remove async from FlutterErrorIntegration #3202

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4682741
Remove async from flutter error integration
buenaflor Aug 27, 2025
870fee4
Update
buenaflor Aug 27, 2025
ef0cf63
Update CHANGELOG
buenaflor Aug 28, 2025
3ff853c
Merge branch 'main' into enh/remove-async-flutter-error-integration
buenaflor Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/flutter/lib/src/integrations/flutter_error_integration.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import 'dart:async';

import 'package:flutter/foundation.dart';
import 'package:sentry/sentry.dart';
import '../sentry_flutter_options.dart';
Expand All @@ -22,7 +24,7 @@ class FlutterErrorIntegration implements Integration<SentryFlutterOptions> {
@override
void call(Hub hub, SentryFlutterOptions options) {
_defaultOnError = FlutterError.onError;
_integrationOnError = (FlutterErrorDetails errorDetails) async {
_integrationOnError = (FlutterErrorDetails errorDetails) {
final exception = errorDetails.exception;

options.log(
Expand Down Expand Up @@ -88,7 +90,7 @@ class FlutterErrorIntegration implements Integration<SentryFlutterOptions> {
stackTrace = getCurrentStackTrace();
hint.addAll({TypeCheckHint.currentStackTrace: true});
}
await hub.captureEvent(event, stackTrace: stackTrace, hint: hint);
unawaited(hub.captureEvent(event, stackTrace: stackTrace, hint: hint));
// we don't call Zone.current.handleUncaughtError because we'd like
// to set a specific mechanism for FlutterError.onError.
} else {
Expand Down
5 changes: 3 additions & 2 deletions packages/flutter/lib/src/integrations/on_error_integration.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import 'dart:async';

import 'package:sentry/sentry.dart';
// ignore: implementation_imports
import 'package:sentry/src/utils/stacktrace_utils.dart';
Expand Down Expand Up @@ -83,8 +85,7 @@ class OnErrorIntegration implements Integration<SentryFlutterOptions> {
stackTrace = getCurrentStackTrace();
hint = Hint.withMap({TypeCheckHint.currentStackTrace: true});
}
// unawaited future
hub.captureEvent(event, stackTrace: stackTrace, hint: hint);
unawaited(hub.captureEvent(event, stackTrace: stackTrace, hint: hint));

return handled;
};
Expand Down
5 changes: 2 additions & 3 deletions packages/flutter/test/integrations/flutter_error_integration_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ void main() {
_mockValues();

// replace default error otherwise it fails on testing
FlutterError.onError =
handler ?? (FlutterErrorDetails errorDetails) async {};
FlutterError.onError = handler ?? (FlutterErrorDetails errorDetails) {};

final sut = fixture.getSut();
sut(fixture.hub, fixture.options);
Expand Down Expand Up @@ -169,7 +168,7 @@ void main() {
_mockValues();

var numberOfDefaultCalls = 0;
final defaultError = (FlutterErrorDetails errorDetails) async {
final defaultError = (FlutterErrorDetails errorDetails) {
numberOfDefaultCalls++;
};
FlutterError.onError = defaultError;
Expand Down
Loading