Fix navigator observer behaviour on didPush root #3111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3111 +/- ##
==========================================
+ Coverage 87.66% 88.34% +0.67%
==========================================
Files 288 98 -190
Lines 9813 3560 -6253
==========================================
- Hits 8603 3145 -5458
+ Misses 1210 415 -795 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2d34233 | 1258.19 ms | 1268.92 ms | 10.73 ms |
| 575ebaa | 1262.20 ms | 1274.24 ms | 12.04 ms |
| 640ad0c | 1241.04 ms | 1253.96 ms | 12.92 ms |
| ec78888 | 1251.37 ms | 1269.40 ms | 18.04 ms |
| 93b7728 | 1247.23 ms | 1264.87 ms | 17.64 ms |
| 2cf9161 | 1248.33 ms | 1266.55 ms | 18.22 ms |
| b6c8720 | 1252.65 ms | 1266.61 ms | 13.96 ms |
| 6ba4675 | 1223.12 ms | 1238.17 ms | 15.04 ms |
| dbd526b | 1244.78 ms | 1259.02 ms | 14.24 ms |
| 73dca78 | 1246.65 ms | 1265.42 ms | 18.76 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2d34233 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 575ebaa | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 640ad0c | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| ec78888 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 93b7728 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 2cf9161 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| b6c8720 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 6ba4675 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| dbd526b | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 73dca78 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| aeb02f2 | 373.84 ms | 437.00 ms | 63.16 ms |
| 6f47800 | 451.04 ms | 509.64 ms | 58.60 ms |
| eca355d | 485.50 ms | 569.85 ms | 84.35 ms |
| b6c8720 | 457.41 ms | 519.04 ms | 61.63 ms |
| 575ebaa | 478.00 ms | 585.76 ms | 107.76 ms |
| 827bf09 | 475.40 ms | 547.14 ms | 71.74 ms |
| 2d34233 | 470.54 ms | 558.90 ms | 88.36 ms |
| 0fb45d0 | 482.79 ms | 554.02 ms | 71.23 ms |
| 81f83eb | 471.40 ms | 522.14 ms | 50.74 ms |
| 9b99523 | 456.91 ms | 490.55 ms | 33.64 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| aeb02f2 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 6f47800 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| eca355d | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| b6c8720 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 575ebaa | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 827bf09 | 6.54 MiB | 7.53 MiB | 1015.27 KiB |
| 2d34233 | 6.54 MiB | 7.55 MiB | 1.01 MiB |
| 0fb45d0 | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| 81f83eb | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 9b99523 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
buenaflor
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
On initial app start we should not:
💡 Motivation and Context
Fixes issues where trace ids are wrong and TTFD not working for root
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps