Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only access renderObject if hasSize is true #2263

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Only access renderObject if hasSize is true #2263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ff7aa9
Only access renderObject if `hasSize` is true
denrase Sep 2, 2024
27aa6ff
add cl entry
denrase Sep 2, 2024
14aaefa
Merge branch 'main' into fix/sentry-widget-render-issues
denrase Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8360)
- [diff](https://github.com/getsentry/sentry-cocoa/compare/8.35.1...8.36.0)

### Fixes

- Only access renderObject if `hasSize` is true ([#2263](https://github.com/getsentry/sentry-dart/pull/2263))

## 8.8.0

### Features
Expand Down
2 changes: 1 addition & 1 deletion flutter/lib/src/view_hierarchy/sentry_tree_walker.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ class _TreeWalker {
double? alpha;

final renderObject = element.renderObject;
if (renderObject is RenderBox) {
if (renderObject is RenderBox && renderObject.hasSize) {
final offset = renderObject.localToGlobal(Offset.zero);
if (offset.dx > 0) {
x = offset.dx;
Expand Down
Loading