Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appHangTimeoutInterval to SentryFlutterOptions #1568

Merged
merged 4 commits into from
Jul 25, 2023

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jul 24, 2023

📜 Description

  • Add appHangTimeoutInterval to SentryFlutterOptions

💡 Motivation and Context

Closes #1550

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2793a8b

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.82% 🎉

Comparison is base (0aaa46e) 90.29% compared to head (2793a8b) 91.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1568      +/-   ##
==========================================
+ Coverage   90.29%   91.11%   +0.82%     
==========================================
  Files         181       61     -120     
  Lines        5830     2049    -3781     
==========================================
- Hits         5264     1867    -3397     
+ Misses        566      182     -384     
Files Changed Coverage Δ
flutter/lib/src/sentry_flutter_options.dart 100.00% <ø> (ø)
...r/lib/src/integrations/native_sdk_integration.dart 100.00% <100.00%> (ø)

... and 120 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denrase denrase marked this pull request as ready for review July 24, 2023 14:50
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 305.94 ms 377.38 ms 71.44 ms
Size 6.16 MiB 7.14 MiB 1007.47 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0a82a1e 321.02 ms 393.82 ms 72.80 ms
322aa66 284.98 ms 341.76 ms 56.78 ms
9c5aec6 287.33 ms 320.94 ms 33.61 ms
f4cc744 349.53 ms 394.68 ms 45.15 ms
b47809a 333.42 ms 368.36 ms 34.95 ms
f2db4ec 372.46 ms 469.72 ms 97.26 ms
f96ca24 316.08 ms 388.22 ms 72.14 ms
f79eecf 341.35 ms 388.98 ms 47.63 ms
0be962b 325.54 ms 382.83 ms 57.29 ms
ecb4003 332.58 ms 385.15 ms 52.57 ms

App size

Revision Plain With Sentry Diff
0a82a1e 6.15 MiB 7.11 MiB 981.82 KiB
322aa66 5.94 MiB 6.92 MiB 1005.75 KiB
9c5aec6 5.94 MiB 6.92 MiB 1001.61 KiB
f4cc744 5.94 MiB 6.95 MiB 1.01 MiB
b47809a 5.94 MiB 6.96 MiB 1.02 MiB
f2db4ec 6.06 MiB 7.03 MiB 990.27 KiB
f96ca24 6.06 MiB 7.10 MiB 1.04 MiB
f79eecf 6.15 MiB 7.13 MiB 1000.07 KiB
0be962b 6.06 MiB 7.03 MiB 990.29 KiB
ecb4003 6.06 MiB 7.09 MiB 1.03 MiB

@marandaneto marandaneto enabled auto-merge (squash) July 25, 2023 08:13
@marandaneto marandaneto merged commit 33d0587 into main Jul 25, 2023
80 of 84 checks passed
@marandaneto marandaneto deleted the feat/app-hang-timeout-interval branch July 25, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add appHangTimeoutInterval option to SentryFlutterOptions
2 participants