-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow sentry user to control resolution of captured Flutter screenshots #1288
Conversation
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1288 +/- ##
==========================================
+ Coverage 88.73% 90.30% +1.56%
==========================================
Files 122 165 +43
Lines 3818 5186 +1368
==========================================
+ Hits 3388 4683 +1295
- Misses 430 503 +73
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@denrase can we add testing for the screen quality? |
@marandaneto Will check if we can add an integration test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @denrase
📜 Description
SentryscreenshotQulity
Full Quality:
Small Quality:
💡 Motivation and Context
Closes #1200
💚 How did you test it?
Ran different resolutions with sample app.
📝 Checklist
sendDefaultPii
is enabled