Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sentry user to control resolution of captured Flutter screenshots #1288

Merged
merged 7 commits into from
Mar 6, 2023

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Feb 20, 2023

📜 Description

  • Introduce SentryscreenshotQulity
  • Render screenshots according to quality
  • We now also support full resolution instead of just rendering logical pixels

Full Quality:
Bildschirm­foto 2023-02-20 um 17 10 12

Small Quality:
Bildschirm­foto 2023-02-20 um 17 15 08

💡 Motivation and Context

Closes #1200

💚 How did you test it?

Ran different resolutions with sample app.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8f236fd

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Patch coverage: 98.10% and project coverage change: +1.56 🎉

Comparison is base (c60752d) 88.73% compared to head (8f236fd) 90.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           v7.0.0    #1288      +/-   ##
==========================================
+ Coverage   88.73%   90.30%   +1.56%     
==========================================
  Files         122      165      +43     
  Lines        3818     5186    +1368     
==========================================
+ Hits         3388     4683    +1295     
- Misses        430      503      +73     
Impacted Files Coverage Δ
dart/lib/src/protocol/contexts.dart 93.89% <ø> (-0.05%) ⬇️
dart/lib/src/protocol/max_body_size.dart 50.00% <ø> (ø)
dart/lib/src/protocol/sentry_baggage_header.dart 100.00% <ø> (ø)
dart/lib/src/protocol/sentry_response.dart 82.75% <ø> (ø)
dart/lib/src/protocol/sentry_transaction_info.dart 70.00% <ø> (ø)
dart/lib/src/sentry_baggage.dart 90.90% <ø> (ø)
dart/lib/src/sentry_span_interface.dart 100.00% <ø> (ø)
dart/lib/src/sentry_trace_context_header.dart 100.00% <ø> (ø)
dart/lib/src/version.dart 100.00% <ø> (ø)
file/lib/src/sentry_file_extension.dart 80.00% <ø> (ø)
... and 69 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@denrase denrase marked this pull request as ready for review February 20, 2023 16:24
@marandaneto
Copy link
Contributor

@denrase can we add testing for the screen quality?

@denrase
Copy link
Collaborator Author

denrase commented Mar 6, 2023

@marandaneto Will check if we can add an integration test.

@denrase denrase requested a review from marandaneto March 6, 2023 10:14
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @denrase

@marandaneto marandaneto merged commit c238d73 into v7.0.0 Mar 6, 2023
@marandaneto marandaneto deleted the feat/screenshot-resolution branch March 6, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants