Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file package min version #1240

Merged
merged 6 commits into from
Jan 25, 2023
Merged

Fix file package min version #1240

merged 6 commits into from
Jan 25, 2023

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jan 24, 2023

📜 Description

#skip-changelog

💡 Motivation and Context

Flutter 3.7 (latest) uses Dart 2.19
Dart latest is 2.19
Closes #1179

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 90.07% // Head: 88.87% // Decreases project coverage by -1.21% ⚠️

Coverage data is based on head (1ba21f3) compared to base (25d647d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
- Coverage   90.07%   88.87%   -1.21%     
==========================================
  Files         117      121       +4     
  Lines        3627     3810     +183     
==========================================
+ Hits         3267     3386     +119     
- Misses        360      424      +64     
Impacted Files Coverage Δ
file/lib/src/sentry_file.dart 54.13% <100.00%> (ø)
logging/lib/src/logging_integration.dart 90.47% <0.00%> (ø)
file/lib/src/sentry_file_extension.dart 80.00% <0.00%> (ø)
logging/lib/src/extension.dart 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 314.58 ms 345.16 ms 30.58 ms
Size 5.94 MiB 6.97 MiB 1.03 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
322aa66 284.98 ms 341.76 ms 56.78 ms
4efee31 308.92 ms 368.68 ms 59.76 ms
873fb42 352.10 ms 397.43 ms 45.33 ms
56810ff 309.72 ms 352.26 ms 42.54 ms
3a69405 334.34 ms 369.19 ms 34.85 ms
521cfbf 332.78 ms 376.04 ms 43.26 ms
af2d175 279.08 ms 312.37 ms 33.29 ms
9928a74 375.26 ms 456.30 ms 81.04 ms
deaeece 347.42 ms 381.10 ms 33.68 ms
f4cc744 349.53 ms 394.68 ms 45.15 ms

App size

Revision Plain With Sentry Diff
322aa66 5.94 MiB 6.92 MiB 1005.75 KiB
4efee31 5.94 MiB 6.92 MiB 1003.76 KiB
873fb42 5.94 MiB 6.96 MiB 1.02 MiB
56810ff 5.94 MiB 6.92 MiB 1001.71 KiB
3a69405 5.94 MiB 6.95 MiB 1.01 MiB
521cfbf 5.94 MiB 6.97 MiB 1.03 MiB
af2d175 5.94 MiB 6.92 MiB 1001.83 KiB
9928a74 5.94 MiB 6.96 MiB 1.02 MiB
deaeece 5.94 MiB 6.96 MiB 1.02 MiB
f4cc744 5.94 MiB 6.95 MiB 1.01 MiB

@github-actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1252.21 ms 1280.76 ms 28.54 ms
Size 8.16 MiB 9.17 MiB 1.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d7758e8 1271.69 ms 1288.08 ms 16.39 ms
9811573 1259.78 ms 1278.33 ms 18.55 ms
b47809a 1252.61 ms 1278.57 ms 25.96 ms
8d64376 1260.92 ms 1289.32 ms 28.40 ms
fbf42af 1253.76 ms 1269.51 ms 15.76 ms
633cf2e 1257.96 ms 1275.73 ms 17.77 ms
deaeece 1252.82 ms 1279.04 ms 26.22 ms
a609134 1254.50 ms 1265.08 ms 10.58 ms
ae02632 1286.77 ms 1300.37 ms 13.60 ms
a510d1d 1277.04 ms 1291.57 ms 14.53 ms

App size

Revision Plain With Sentry Diff
d7758e8 8.15 MiB 9.12 MiB 989.76 KiB
9811573 8.16 MiB 9.17 MiB 1.01 MiB
b47809a 8.16 MiB 9.17 MiB 1.01 MiB
8d64376 8.16 MiB 9.17 MiB 1.01 MiB
fbf42af 8.16 MiB 9.17 MiB 1.01 MiB
633cf2e 8.15 MiB 9.12 MiB 986.26 KiB
deaeece 8.16 MiB 9.17 MiB 1.01 MiB
a609134 8.16 MiB 9.16 MiB 1.01 MiB
ae02632 8.16 MiB 9.15 MiB 1020.68 KiB
a510d1d 8.16 MiB 9.17 MiB 1.01 MiB

@marandaneto marandaneto merged commit c70e01a into main Jan 25, 2023
@marandaneto marandaneto deleted the fix/file-dart-min-version branch January 25, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New File interface affects SentryFile
2 participants