Do not allow setting measurement if transaction is finished #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
approved these changes
Sep 28, 2022
marandaneto
requested review from
brustolin and
krystofwoldrich
as code owners
marandaneto
changed the title
philipphofmann
changed the title
philipphofmann
approved these changes
Sep 29, 2022
| @@ -284,6 +284,9 @@ class SentryTracer extends ISentrySpan { | |||
|
|
|||
| @override | |||
| void setMeasurement(String name, num value, {SentryMeasurementUnit? unit}) { | |||
| if (finished) { | |||
| return; | |||
There was a problem hiding this comment.
l: Maybe log a debug message.
There was a problem hiding this comment.
There's a separate issue to make the tracer loggable because we don't have the instance of the logger, but we'll do it soon.
5 tasks
Codecov ReportBase: 90.12% // Head: 91.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
==========================================
+ Coverage 90.12% 91.37% +1.24%
==========================================
Files 114 9 -105
Lines 3554 197 -3357
==========================================
- Hits 3203 180 -3023
+ Misses 351 17 -334 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Related to #1011.
💡 Motivation and Context
Does not allow setting measurement if transaction is finished
💚 How did you test it?
📝 Checklist
🔮 Next steps