Enable detailed breadcrumbs for HTTP error responses in Dio’s Sentry Interceptor

[dalnoki]

Problem Statement

Currently, Dio’s Sentry interceptor behaves as follows:

On a successful HTTP response, the interceptor records duration, start_timestamp, end_timestamp, reason and http.query as a breadcrumb.

On an error (non-2xx response or network failure), the breadcrumb only contains duration, start_timestamp and end_timestamp.

It would be nice to have the same information in breadcrumb for both successful and unsuccessful requests.

Solution Brainstorm

No response

Are you willing to submit a PR?

None

[buenaflor]

I'll have a look there 👍

[denrase]

@dalnoki Could you check in our breadcrumbs what the SentryLevel is? If it is error, it's because the fetch is throwing, and therefore we do not have a response object (statusCode, statusMessage) to attach. In other cases the data should be there.

try {
  final response =  await _client.fetch(options, requestStream, cancelFuture);
  
  // Not reached if fetch throws...
  statusCode = response.statusCode;
  reason = response.statusMessage;
  ...
} catch (_) {
  // Happens when fetch is throwing...
  requestHadException = true; 
  ...
} finally {
  stopwatch.stop();
  ...
  if (requestHadException) {
    // If this was set, we know it was a throwing fetch.
    level = SentryLevel.error; 
  }
  ...
}

[dalnoki]

Hi @denrase sorry, this got lost in my notifications. I only have a screenshot from the customer, but it seems to be an error breadcrumb, yes