Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance package validation + Remove Symbolic Links #267

Merged
merged 8 commits into from
Apr 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ jobs:
GITHUB_ACCESS_TOKEN: ${{ secrets.GH_RELEASE_PAT }}
run: make build


job_artifacts:
name: Upload Artifacts
needs: [job_build, job_carthage_build]
Expand Down Expand Up @@ -160,3 +159,34 @@ jobs:
name: ${{ github.sha }}
path: |
${{ github.workspace }}/sentry-cordova-*

job_check_symlink:
name: Check for Symbolic Links
needs: [job_artifacts]
runs-on: macos-latest
defaults:
run:
shell: pwsh
steps:
- name: Checkout
uses: actions/[email protected]

- name: Download test app artifact
uses: actions/download-artifact@v2
with:
name: ${{ github.sha }}
path: |
${{ github.workspace }}/artifact
- name: Extract artifact
run: |
cd ${{ github.workspace }}/artifact
$bundleName = (Get-Item *.tgz).Name
tar -xvzf "$bundleName"

- name: Check if package contains any Symlink
run: |
$symLinks = (find "${{ github.workspace }}" -type l -ls)
if ($null -ne $symLinks) {
Write-Error "Atfifact contains illegal SymLinks`n$symLinks"
}
Write-Output "No Symbolic Links found, all good :)"
2 changes: 1 addition & 1 deletion .npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
*
!/dist/**/*
!/src/ios/Carthage/Build/Sentry.xcframework/**/*
!/src/ios/Carthage/Build/Sentry.xcframework/ios-*/**/*
!/src/ios/SentryCordova.*
!/src/android/**/*
!/scripts/**/*
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Fixes

- Enhance package validation and Removed Symbolic Links ([#267](https://github.com/getsentry/sentry-cordova/pull/267))
- Sentry.xcframework being excluded by npm rule ([#266](https://github.com/getsentry/sentry-cordova/pull/266))

## 1.0.1
Expand Down