Conversation
…tionTracker to Swift Migrate the Logic and Tracker classes from Objective-C to Swift while keeping the Integration in Objective-C for now. The Swift classes are marked with @objc and @_spi(Private) to maintain compatibility with the existing Objective-C Integration. Changes: - Add SentryWatchdogTerminationLogic.swift with @objc support - Add SentryWatchdogTerminationTracker.swift with @objc support - Remove old Objective-C implementations - Update imports in Integration and other files to use Swift versions - Update test data to reference Swift class properties - Update bridging header to remove obsolete imports
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7118 +/- ##
=============================================
+ Coverage 84.710% 84.802% +0.091%
=============================================
Files 459 461 +2
Lines 27490 27859 +369
Branches 12117 12321 +204
=============================================
+ Hits 23287 23625 +338
- Misses 4162 4193 +31
Partials 41 41
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 013fd4d | 1216.02 ms | 1242.16 ms | 26.14 ms |
| d29a425 | 1209.96 ms | 1239.00 ms | 29.04 ms |
| 9f7ef2b | 1213.53 ms | 1250.23 ms | 36.70 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 013fd4d | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| d29a425 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 9f7ef2b | 24.14 KiB | 1.04 MiB | 1.02 MiB |
7 tasks
Sources/Swift/Integrations/WatchdogTerminations/SentryWatchdogTerminationLogic.swift
Show resolved
Hide resolved
Sources/Swift/Integrations/WatchdogTerminations/SentryWatchdogTerminationLogic.swift
Show resolved
Hide resolved
philprime
reviewed
Jan 8, 2026
Member
philprime
left a comment
There was a problem hiding this comment.
Good progress, left some comments to discuss
Sources/Swift/Integrations/WatchdogTerminations/SentryWatchdogTerminationTracker.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/WatchdogTerminations/SentryWatchdogTerminationTracker.swift
Show resolved
Hide resolved
Sources/Swift/Integrations/WatchdogTerminations/SentryWatchdogTerminationLogic.swift
Show resolved
Hide resolved
Sources/Swift/Integrations/WatchdogTerminations/SentryWatchdogTerminationLogic.swift
Show resolved
Hide resolved
Tests/SentryTests/Integrations/MetricKit/SentryMetricKitEventTests.swift
Outdated
Show resolved
Hide resolved
…Tests, SentryMetricKitEventTests, and TestData. This simplifies the test files by eliminating unnecessary preprocessor directives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Changes:
SentrySwift.h
💡 Motivation and Context
These changes are needed to convert SentryWatchdogTerminationIntegration to Swift
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.No public changes, #skip-changelog
Closes #7127