chore: Remove SentryNetworkTracker singleton#7107
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7107 +/- ##
=============================================
+ Coverage 84.714% 84.746% +0.032%
=============================================
Files 459 459
Lines 27496 27508 +12
Branches 12121 12125 +4
=============================================
+ Hits 23293 23312 +19
+ Misses 4160 4155 -5
+ Partials 43 41 -2
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…nm-in-swift' of github.com:getsentry/sentry-cocoa into itay/remove_networktracker_singleton
Contributor
Performance metrics 🚀
|
Contributor
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
7 tasks
Base automatically changed from
itay/cocoa-993-refactor-sentrynetworktrackingintegrationm-in-swift
to
main
January 15, 2026 19:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Follow up to remove SentryNetworkTracking singleton.
After testing this more, I noticed that at least some kind of singleton is needed because of the swizzling + closing and enabling again the SDK.
I found another way to implement this.
But I am not sure this is the way to go, because in the end I traded one singleton for another.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.