-
-
Notifications
You must be signed in to change notification settings - Fork 377
chore: Remove swift5.9 checks #7098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7098 +/- ##
=============================================
+ Coverage 84.769% 84.773% +0.003%
=============================================
Files 459 459
Lines 27517 27517
Branches 12132 12136 +4
=============================================
+ Hits 23326 23327 +1
Misses 4149 4149
+ Partials 42 41 -1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9ec4c56 | 1222.69 ms | 1248.77 ms | 26.08 ms |
| 2699f74 | 1229.90 ms | 1264.60 ms | 34.71 ms |
| 130c6ba | 1237.02 ms | 1259.67 ms | 22.65 ms |
| 856fffe | 1232.69 ms | 1245.80 ms | 13.10 ms |
| f4f94f5 | 1216.24 ms | 1247.94 ms | 31.70 ms |
| aa643c5 | 1228.25 ms | 1261.08 ms | 32.83 ms |
| 82f60cf | 1218.65 ms | 1238.52 ms | 19.87 ms |
| a2a3bfb | 1227.94 ms | 1261.26 ms | 33.32 ms |
| d3b0d62 | 1234.78 ms | 1262.69 ms | 27.91 ms |
| 6502818 | 1229.08 ms | 1245.46 ms | 16.37 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9ec4c56 | 23.75 KiB | 921.20 KiB | 897.45 KiB |
| 2699f74 | 24.14 KiB | 1023.19 KiB | 999.04 KiB |
| 130c6ba | 23.75 KiB | 926.65 KiB | 902.89 KiB |
| 856fffe | 23.75 KiB | 975.18 KiB | 951.44 KiB |
| f4f94f5 | 23.75 KiB | 988.02 KiB | 964.27 KiB |
| aa643c5 | 23.75 KiB | 1015.07 KiB | 991.32 KiB |
| 82f60cf | 23.75 KiB | 913.63 KiB | 889.88 KiB |
| a2a3bfb | 23.75 KiB | 872.67 KiB | 848.92 KiB |
| d3b0d62 | 23.75 KiB | 913.42 KiB | 889.67 KiB |
| 6502818 | 23.75 KiB | 959.45 KiB | 935.70 KiB |
📜 Description
Remove Swift 5.9 checks since we are building with Xcode 16 now.
💡 Motivation and Context
The motivation is removing unnecessary code in our codebase.
💚 How did you test it?
Make sure the library builds on Xcode locally
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.Closes #7099