Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Dec 23, 2025

SentryScreenshotOptions.swift appeared twice in the project, thus generating a warning when building.

Removed one of the instances.

Closes #7094

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Dec 23, 2025
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.802%. Comparing base (f3bb63c) to head (5688ba5).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #7093       +/-   ##
=============================================
+ Coverage   84.769%   84.802%   +0.032%     
=============================================
  Files          459       459               
  Lines        27517     27517               
  Branches     12132     12135        +3     
=============================================
+ Hits         23326     23335        +9     
+ Misses        4149      4140        -9     
  Partials        42        42               

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3bb63c...5688ba5. Read the comment docs.

@itaybre itaybre enabled auto-merge (squash) December 23, 2025 20:49
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.42 ms 1257.70 ms 36.28 ms
Size 24.14 KiB 1.03 MiB 1.00 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2481950 1221.04 ms 1248.98 ms 27.94 ms
08fc5f9 1237.84 ms 1270.06 ms 32.23 ms
fb611a9 1222.63 ms 1254.79 ms 32.16 ms
fe83264 1193.57 ms 1220.43 ms 26.85 ms
c7a1563 1186.80 ms 1232.81 ms 46.02 ms
5d238d3 1228.94 ms 1253.04 ms 24.10 ms
ef2c9b3 1222.12 ms 1253.96 ms 31.84 ms
3279d4e 1215.76 ms 1256.45 ms 40.69 ms
a9fac2e 1212.45 ms 1219.67 ms 7.22 ms
1936411 1231.51 ms 1253.27 ms 21.76 ms

App size

Revision Plain With Sentry Diff
2481950 23.74 KiB 872.74 KiB 849.00 KiB
08fc5f9 23.75 KiB 995.43 KiB 971.68 KiB
fb611a9 23.74 KiB 1022.38 KiB 998.64 KiB
fe83264 23.75 KiB 1.01 MiB 1006.48 KiB
c7a1563 24.15 KiB 1.01 MiB 1014.90 KiB
5d238d3 23.75 KiB 913.62 KiB 889.88 KiB
ef2c9b3 23.75 KiB 933.03 KiB 909.29 KiB
3279d4e 23.75 KiB 938.32 KiB 914.57 KiB
a9fac2e 23.75 KiB 879.53 KiB 855.78 KiB
1936411 23.74 KiB 913.39 KiB 889.64 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Remove duplicate file in project

3 participants