-
-
Notifications
You must be signed in to change notification settings - Fork 377
fix: Update raw_description in runtime context for Mac Catalyst App #7082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated the runtime context's raw_description value from "raw_description" to "mac-catalyst-app" in SentryCrashWrapper. Adjusted corresponding tests to reflect this change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7082 +/- ##
=============================================
- Coverage 84.867% 84.853% -0.015%
=============================================
Files 459 459
Lines 27517 27517
Branches 12126 12135 +9
=============================================
- Hits 23353 23349 -4
- Misses 4123 4125 +2
- Partials 41 43 +2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
itaybre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find, LGTM
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 854ca12 | 1219.94 ms | 1251.32 ms | 31.38 ms |
| 2675d3c | 1218.94 ms | 1239.36 ms | 20.42 ms |
| 6ad363f | 1196.04 ms | 1223.27 ms | 27.23 ms |
| 87fb58a | 1233.12 ms | 1257.17 ms | 24.04 ms |
| 449d185 | 1216.31 ms | 1251.94 ms | 35.62 ms |
| d3f650a | 1225.45 ms | 1241.86 ms | 16.41 ms |
| 99104c9 | 1224.84 ms | 1247.08 ms | 22.24 ms |
| 0f410ad | 1193.34 ms | 1255.49 ms | 62.15 ms |
| f8029e2 | 1245.16 ms | 1261.32 ms | 16.16 ms |
| e3ebff3 | 1223.47 ms | 1249.27 ms | 25.80 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 854ca12 | 23.74 KiB | 996.96 KiB | 973.22 KiB |
| 2675d3c | 23.75 KiB | 928.16 KiB | 904.41 KiB |
| 6ad363f | 23.75 KiB | 1022.66 KiB | 998.91 KiB |
| 87fb58a | 23.75 KiB | 919.91 KiB | 896.16 KiB |
| 449d185 | 23.75 KiB | 980.81 KiB | 957.06 KiB |
| d3f650a | 23.75 KiB | 902.48 KiB | 878.73 KiB |
| 99104c9 | 23.75 KiB | 894.83 KiB | 871.09 KiB |
| 0f410ad | 24.14 KiB | 1.01 MiB | 1014.82 KiB |
| f8029e2 | 23.75 KiB | 893.72 KiB | 869.97 KiB |
| e3ebff3 | 23.75 KiB | 878.48 KiB | 854.73 KiB |
Updated the runtime context's raw_description value from "raw_description" to "mac-catalyst-app" in SentryCrashWrapper. Adjusted corresponding tests to reflect this change.
Closes #7083