Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Dec 12, 2025

Converts SentryScreenshotIntegration to Swift

While I tried not using SentryDependencyContainer anymore, the C block requires a global variable.

#skip-changelog

Closes #7047

@linear
Copy link

linear bot commented Dec 12, 2025

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Dec 12, 2025
@codecov
Copy link

codecov bot commented Dec 12, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4084 1 4083 24
View the full list of 1 ❄️ flaky test(s)
SentryTests.SentryOnDemandReplayTests::testAddFrameIsThreadSafe

Flake rate in main: 100.00% (Passed 0 times, Failed 38 times)

Stack Traces | 0s run time
.../Integrations/SessionReplay/SentryOnDemandReplayTests.swift:139 - Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "AddFrameIsThreadSafe".

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1211.37 ms 1255.29 ms 43.91 ms
Size 24.14 KiB 1.03 MiB 1.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7a8b167 1217.49 ms 1247.67 ms 30.18 ms
3cdbc22 1231.63 ms 1251.06 ms 19.43 ms
748df9d 1231.63 ms 1259.47 ms 27.84 ms
3319d58 1226.46 ms 1256.56 ms 30.10 ms
ebc3a34 1236.24 ms 1261.02 ms 24.78 ms
8cf2d43 1217.60 ms 1270.27 ms 52.67 ms
e16fd46 1228.64 ms 1251.57 ms 22.93 ms
e8e40fd 1222.10 ms 1259.91 ms 37.80 ms
b9aacb6 1230.42 ms 1251.00 ms 20.58 ms
c7a1563 1186.80 ms 1232.81 ms 46.02 ms

App size

Revision Plain With Sentry Diff
7a8b167 24.14 KiB 1.01 MiB 1014.00 KiB
3cdbc22 23.75 KiB 928.14 KiB 904.40 KiB
748df9d 23.75 KiB 902.48 KiB 878.74 KiB
3319d58 23.75 KiB 1021.48 KiB 997.73 KiB
ebc3a34 23.75 KiB 919.91 KiB 896.16 KiB
8cf2d43 23.75 KiB 971.98 KiB 948.23 KiB
e16fd46 23.74 KiB 1.01 MiB 1008.95 KiB
e8e40fd 23.75 KiB 1022.79 KiB 999.04 KiB
b9aacb6 23.75 KiB 913.64 KiB 889.89 KiB
c7a1563 24.15 KiB 1.01 MiB 1014.90 KiB

Previous results on branch: itay/cocoa-983-refactor-sentryscreenshotintegrationm-with-new-swift-style

Startup times

Revision Plain With Sentry Diff
5f3bfbb 1215.79 ms 1255.40 ms 39.61 ms
0d3e3b8 1193.39 ms 1218.17 ms 24.78 ms

App size

Revision Plain With Sentry Diff
5f3bfbb 24.14 KiB 1.03 MiB 1.01 MiB
0d3e3b8 24.14 KiB 1.03 MiB 1.01 MiB

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itaybre itaybre merged commit 998adc8 into main Dec 16, 2025
239 of 246 checks passed
@itaybre itaybre deleted the itay/cocoa-983-refactor-sentryscreenshotintegrationm-with-new-swift-style branch December 16, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Convert SentryScreenshotIntegration to Swift

3 participants