Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Dec 12, 2025

Looks like I forgot to change this comment when I removed the UIWindow notification approach in V9 here: #6008

#skip-changelog

Closes #7035

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.271%. Comparing base (83cd14a) to head (fb9a28c).
⚠️ Report is 11 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #7034       +/-   ##
=============================================
+ Coverage   85.070%   85.271%   +0.200%     
=============================================
  Files          454       458        +4     
  Lines        27737     28156      +419     
  Branches     12157     12464      +307     
=============================================
+ Hits         23596     24009      +413     
+ Misses        4096      3889      -207     
- Partials        45       258      +213     

see 70 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83cd14a...fb9a28c. Read the comment docs.

Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itaybre
Copy link
Contributor

itaybre commented Dec 12, 2025

Can you link the related PR in the comments here?

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@noahsmartin noahsmartin added the ready-to-merge Use this label to trigger all PR workflows label Dec 15, 2025
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.22 ms 1249.56 ms 24.34 ms
Size 24.14 KiB 1.03 MiB 1.00 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c6c1cb7 1235.71 ms 1263.80 ms 28.08 ms
83265fc 1212.33 ms 1242.31 ms 29.98 ms
27e7514 1229.47 ms 1245.60 ms 16.13 ms
996b997 1188.71 ms 1209.36 ms 20.65 ms
be8375a 1212.65 ms 1239.72 ms 27.08 ms
1b15a2a 1227.13 ms 1254.80 ms 27.66 ms
6cb4338 1238.47 ms 1256.96 ms 18.49 ms
b714cb9 1224.71 ms 1238.04 ms 13.33 ms
59fc426 1240.49 ms 1256.94 ms 16.45 ms
00d9740 1223.53 ms 1249.75 ms 26.22 ms

App size

Revision Plain With Sentry Diff
c6c1cb7 23.75 KiB 928.15 KiB 904.40 KiB
83265fc 23.75 KiB 1022.78 KiB 999.03 KiB
27e7514 23.75 KiB 919.69 KiB 895.94 KiB
996b997 24.14 KiB 1.01 MiB 1012.94 KiB
be8375a 23.75 KiB 933.03 KiB 909.28 KiB
1b15a2a 24.14 KiB 1.01 MiB 1013.56 KiB
6cb4338 23.75 KiB 913.63 KiB 889.88 KiB
b714cb9 23.75 KiB 858.69 KiB 834.93 KiB
59fc426 23.75 KiB 920.64 KiB 896.89 KiB
00d9740 23.75 KiB 938.32 KiB 914.57 KiB

@noahsmartin noahsmartin merged commit 0af32ae into main Dec 16, 2025
275 of 288 checks passed
@noahsmartin noahsmartin deleted the updateAppStartComment branch December 16, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Outdated app launch comment

4 participants