-
-
Notifications
You must be signed in to change notification settings - Fork 375
chore: Ensure required simulators are loaded for all platforms #7022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7022 +/- ##
=============================================
+ Coverage 85.041% 85.046% +0.004%
=============================================
Files 454 454
Lines 27703 27739 +36
Branches 12150 12159 +9
=============================================
+ Hits 23559 23591 +32
- Misses 4100 4104 +4
Partials 44 44 see 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 53b722c | 1222.33 ms | 1244.90 ms | 22.56 ms |
| 6e99155 | 1223.96 ms | 1249.25 ms | 25.29 ms |
| caa7e70 | 1233.61 ms | 1259.13 ms | 25.52 ms |
| 2c7bc4b | 1226.68 ms | 1252.26 ms | 25.58 ms |
| daeb716 | 1215.41 ms | 1246.52 ms | 31.11 ms |
| 326984b | 1235.06 ms | 1252.75 ms | 17.69 ms |
| d7dcd2c | 1215.04 ms | 1247.40 ms | 32.36 ms |
| 94a6b1a | 1213.39 ms | 1231.55 ms | 18.17 ms |
| 7c7ac56 | 1225.90 ms | 1250.22 ms | 24.33 ms |
| 5b90eb2 | 1233.04 ms | 1267.94 ms | 34.89 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 53b722c | 23.75 KiB | 906.08 KiB | 882.33 KiB |
| 6e99155 | 23.75 KiB | 963.18 KiB | 939.43 KiB |
| caa7e70 | 23.75 KiB | 1004.68 KiB | 980.94 KiB |
| 2c7bc4b | 24.14 KiB | 1.02 MiB | 1017.39 KiB |
| daeb716 | 23.75 KiB | 928.16 KiB | 904.41 KiB |
| 326984b | 23.74 KiB | 926.64 KiB | 902.90 KiB |
| d7dcd2c | 24.14 KiB | 1.02 MiB | 1020.15 KiB |
| 94a6b1a | 23.75 KiB | 902.48 KiB | 878.74 KiB |
| 7c7ac56 | 23.75 KiB | 902.49 KiB | 878.74 KiB |
| 5b90eb2 | 23.75 KiB | 1023.81 KiB | 1000.07 KiB |
Some Cirrus Labs are also failing because the tvOS runtime wasn't loaded.
Added a platform option to the runtime check to verify all platforms.
Closes #7023