-
-
Notifications
You must be signed in to change notification settings - Fork 377
Log Integrations: Add SentrySwiftyBeaver Integration
#7021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7021 +/- ##
=============================================
+ Coverage 85.062% 85.115% +0.052%
=============================================
Files 468 468
Lines 28305 28305
Branches 12532 12542 +10
=============================================
+ Hits 24077 24092 +15
+ Misses 4183 4172 -11
+ Partials 45 41 -4 see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
philprime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3rd-party-integrations/SentrySwiftyBeaver/Sources/SentryDestination.swift
Outdated
Show resolved
Hide resolved
…clarity and consistency. Updated corresponding tests to reflect these changes.
Co-authored-by: Philip Niedertscheider <[email protected]>
…ration tests in coverage and unit test filters.
…/sentry-cocoa into feat/add-swift-log-integration
…aver-integration # Conflicts: # Utils/VersionBump/main.swift
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
#skip-changelog
📜 Description
SentrySwiftyBeaverintegration to the3rd-party-integrations/SentrySwiftyBeaverfolder💡 Motivation and Context
Closes #6277
Relates to #6902
💚 How did you test it?
Package.swiftversion📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.