-
-
Notifications
You must be signed in to change notification settings - Fork 410
feat(metrics): Add implementation for metrics envelope item #6960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 87 commits
Commits
Show all changes
102 commits
Select commit
Hold shift + click to select a range
196c9aa
feat(metrics): Add integration with installation by SDK
philprime 81d9980
update changelog
philprime 420d68e
update changelog
philprime dcc65ff
change type of SUT in MetricsIntegrationTests
philprime 46e42f5
Add metrics to TestOptions.removeAllIntegrations
philprime 8dfb9e6
change default value in disableEverything
philprime 1210307
add missing test tear down
philprime 303d533
feat(metrics): Add implementation for metrics envelope item
philprime b991cda
Remove unrelated change
philprime e5611fb
Add enableMetrics to public header
philprime 2aa1f43
fix compilation
philprime 6dfe9bb
Merge branch 'philprime/metrics-bootstrap' into philprime/metrics-env…
philprime 3ca02d7
refactor(refactor): Add generic internal item batcher
philprime 193c27b
Add SentryItemBatcherTests to enhance item batching functionality
philprime b1891d3
fixed tests and added more protocols
philprime e89eab0
Merge remote-tracking branch 'origin/main' into philprime/log-batcher…
philprime eb09954
refactor item batcher
philprime cc065bb
refactor item batcher into protocols
philprime 8be32e7
cleanup
philprime 21d4e61
Update Sources/Swift/Protocol/SentryAttribute.swift
philprime c17ef37
Enhance Batcher and TestCurrentDateProvider functionality
philprime 421210a
Merge branch 'philprime/log-batcher-abstraction' into philprime/metrics
philprime d3c3b47
Merge branch 'philprime/metrics' into philprime/metrics-bootstrap
philprime 0ae250e
Merge branch 'philprime/metrics-bootstrap' into philprime/metrics-env…
philprime f463844
Merge remote-tracking branch 'origin/main' into philprime/metrics
philprime 6a56d9c
Merge branch 'philprime/metrics' into philprime/metrics-bootstrap
philprime a7c7df9
Merge branch 'philprime/metrics-bootstrap' into philprime/metrics-env…
philprime f17e9e1
Merge remote-tracking branch 'origin/main' into philprime/metrics
philprime c46d92c
Merge branch 'philprime/metrics' into philprime/metrics-bootstrap
philprime c143d90
Merge branch 'philprime/metrics-bootstrap' into philprime/metrics-env…
philprime 70d5fd3
refactor latest item batcher
philprime 64cc81f
fixes
philprime c69eb95
update changelog
philprime 5f4299a
Remove unneeded code
philprime f7a67bb
Merge branch 'philprime/metrics-bootstrap' into philprime/metrics-env…
philprime 70241f7
cleanup
philprime 46a2f3e
add missing options setter
philprime 40b52a3
Merge branch 'philprime/metrics-bootstrap' into philprime/metrics-env…
philprime 861161b
cleanup
philprime c6ce033
WIP
philprime d073e22
WIP
philprime 4980aad
cleanup
philprime 56320d5
Remove spanId from Metric struct and related tests; update BatcherSco…
philprime 3eca8ca
fix warnings on set
philprime 1b939e6
add comment explaining reasoning for jsonserialization in tests
philprime 6ece2f8
test: Add unit tests for enabling and disabling metrics feature
philprime 1d80fda
test: Update MetricsIntegrationTests to assert integration name
philprime 06e863a
Merge branch 'philprime/metrics-bootstrap' into philprime/metrics-env…
philprime 74902aa
WIP
philprime 6dca42f
Update Sources/Swift/Integrations/Metrics/MetricsIntegration.swift
philprime 922ea27
WIP
philprime b9ed1a3
fix integration setup in tests
philprime 99f563e
Merge remote-tracking branch 'origin/main' into philprime/metrics-boo…
philprime 2a05eb7
Merge branch 'philprime/metrics-bootstrap' into philprime/metrics-env…
philprime c8b4ab5
fix tests for integraiton checking
philprime bd60a8c
fix(logs): Use sendDefaultPii and span_id for attributes
philprime 3a22103
Update changelog
philprime 23057b4
Merge branch 'philprime/logs-span-id' into philprime/metrics-bootstrap
philprime 1a6cf02
Merge branch 'philprime/metrics-bootstrap' into philprime/metrics-env…
philprime 62ee6ad
change metric batcher to struct
philprime fe0a0ef
update public api
philprime e3c7019
update public api
philprime f10a253
update changelog
philprime 28fc0dd
Apply suggestions from code review
philprime 3b2eba9
remove scope sendDefaultPii
philprime ac1b46e
remove scope sendDefaultPii
philprime 872c2d4
Update CHANGELOG.md
philprime f8dd108
fix test assert
philprime b092849
Merge remote-tracking branch 'origin/philprime/logs-span-id' into phi…
philprime 5dab77e
move option to experimental
philprime 15f7316
Merge remote-tracking branch 'origin/main' into philprime/metrics-boo…
philprime 0a2b72f
move option to experimental
philprime 86e21d3
cleanup
philprime f9efc90
Merge branch 'philprime/metrics-bootstrap' into philprime/metrics-env…
philprime a12babf
WIP
philprime ba4edde
cleanup
philprime 57b889a
move option to experimental
philprime 7f2f81d
cleanup
philprime 31dc8c8
remove duplicate setter
philprime 28d56ce
apply feedback from PR review
philprime 8d2f500
change encodable conformance to be internal
philprime 146146e
update public api
philprime 19293d4
Refactor SentryMetricsBatcher: Update buffer size to 1MB, enhance doc…
philprime 0273433
fix experimental options and add beforeSendMetrics to changelog
philprime 7e9e86f
Merge remote-tracking branch 'origin/main' into philprime/metrics-boo…
philprime 14f9cdd
add missing experimental subtype
philprime 082e70b
Merge branch 'philprime/metrics-bootstrap' into philprime/metrics-env…
philprime e61661b
Merge remote-tracking branch 'origin/main' into philprime/metrics-boo…
philprime b9bd8cc
Merge branch 'philprime/metrics-bootstrap' into philprime/metrics-env…
philprime 84255ec
Refactor SentryMetric to merge value and type
philprime d73700c
apply feedback from PR review
philprime 550d3cb
Merge remote-tracking branch 'origin/main' into philprime/metrics-boo…
philprime 21f64bd
Merge branch 'philprime/metrics-bootstrap' into philprime/metrics-env…
philprime 51775d5
Merge remote-tracking branch 'origin/main' into philprime/metrics-boo…
philprime 54b3eeb
Merge remote-tracking branch 'origin/main' into philprime/metrics-boo…
philprime ebe0984
Merge branch 'philprime/metrics-bootstrap' into philprime/metrics-env…
philprime 8639f31
revert unneeded changes
philprime 38467ab
refactor: Update SentryMetric attribute handling to use SentryAttribu…
philprime b715cd2
fix: use span traceId when span is active in BatcherScope
philprime be43bd8
fix: correct attribute assignment in SentryMetric to use string initi…
philprime 2c83491
test: fix testApplyToItem_withAllAttributes to set span traceId
philprime 0ebf819
Merge remote-tracking branch 'origin/main' into philprime/metrics-env…
philprime File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.