Skip to content

fix: Use correct parsing for stackframes #6908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noahsmartin merged 9 commits into from
Dec 19, 2025
+270 −408
Merged

fix: Use correct parsing for stackframes #6908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b6867a8
fix: Use correct parsing for stackframes
noahsmartin Nov 25, 2025
f52d0a0
Simplify
noahsmartin Dec 1, 2025
70ad245
Testing
noahsmartin Dec 5, 2025
e46580b
more
noahsmartin Dec 7, 2025
02b2a43
Updates
noahsmartin Dec 10, 2025
444e963
Fixes
noahsmartin Dec 10, 2025
2089345
Update changelog
noahsmartin Dec 11, 2025
bd44249
PR comments
noahsmartin Dec 17, 2025
ac40ad2
PR comments
noahsmartin Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Change default attributes of Logs to only include user attributes when `options.sendDefaultPii = true` (#7055)
- Rename log attribute `sentry.trace.parent_span_id` to `span_id` (#7055)
- Fixes stacktraces for MetricKit events (#6908)

## 9.1.0

Expand Down
16 changes: 16 additions & 0 deletions Sentry.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1101,6 +1101,8 @@
FA914E592ECF968500C54BDD /* UserFeedbackIntegration.swift in Sources */ = {isa = PBXBuildFile; fileRef = FA914E532ECF968000C54BDD /* UserFeedbackIntegration.swift */; };
FA914E5B2ECF988900C54BDD /* Integrations.swift in Sources */ = {isa = PBXBuildFile; fileRef = FA914E5A2ECF988700C54BDD /* Integrations.swift */; };
FA914E6D2ECFD7D800C54BDD /* SentryFeedbackAPI.swift in Sources */ = {isa = PBXBuildFile; fileRef = FA914E6C2ECFD7D800C54BDD /* SentryFeedbackAPI.swift */; };
FA914E9B2ED61AA800C54BDD /* SentryFormatterSwift.h in Headers */ = {isa = PBXBuildFile; fileRef = FA914E952ED61AA300C54BDD /* SentryFormatterSwift.h */; };
FA914E9E2ED61BA800C54BDD /* SentryFormatterSwift.m in Sources */ = {isa = PBXBuildFile; fileRef = FA914E9C2ED61AB900C54BDD /* SentryFormatterSwift.m */; };
FA94E6912E6B92C100576666 /* SentryClientReport.swift in Sources */ = {isa = PBXBuildFile; fileRef = FA94E68B2E6B92BE00576666 /* SentryClientReport.swift */; };
FA94E6B22E6D265800576666 /* SentryEnvelope.swift in Sources */ = {isa = PBXBuildFile; fileRef = FA94E6B12E6D265500576666 /* SentryEnvelope.swift */; };
FA94E7242E6F339400576666 /* SentryEnvelopeItemType.swift in Sources */ = {isa = PBXBuildFile; fileRef = FA94E7232E6F32FA00576666 /* SentryEnvelopeItemType.swift */; };
Expand Down Expand Up @@ -1155,6 +1157,8 @@
FAEEC0522E75E55F00E79CA9 /* SentrySerializationSwift.swift in Sources */ = {isa = PBXBuildFile; fileRef = FAEEC04C2E75E55A00E79CA9 /* SentrySerializationSwift.swift */; };
FAEFA12F2E4FAE1900C431D9 /* SentrySDKSettings.swift in Sources */ = {isa = PBXBuildFile; fileRef = FAEFA1292E4FAE1700C431D9 /* SentrySDKSettings.swift */; };
FAF0F3D02EA7DD0D00E44E9B /* SentryANRTrackerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = FAF0F3CA2EA7DD0700E44E9B /* SentryANRTrackerTests.swift */; };
FAFA358D2EF2FD2A006B145F /* SentryMXCallStackTree+Parsing.swift in Sources */ = {isa = PBXBuildFile; fileRef = FAFA35872EF2FD24006B145F /* SentryMXCallStackTree+Parsing.swift */; };
FAFA358F2EF2FD8F006B145F /* MXSample.swift in Sources */ = {isa = PBXBuildFile; fileRef = FAFA358E2EF2FD8C006B145F /* MXSample.swift */; };
/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
Expand Down Expand Up @@ -2487,6 +2491,8 @@
FA914E532ECF968000C54BDD /* UserFeedbackIntegration.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UserFeedbackIntegration.swift; sourceTree = "<group>"; };
FA914E5A2ECF988700C54BDD /* Integrations.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Integrations.swift; sourceTree = "<group>"; };
FA914E6C2ECFD7D800C54BDD /* SentryFeedbackAPI.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SentryFeedbackAPI.swift; sourceTree = "<group>"; };
FA914E952ED61AA300C54BDD /* SentryFormatterSwift.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = SentryFormatterSwift.h; path = include/SentryFormatterSwift.h; sourceTree = "<group>"; };
FA914E9C2ED61AB900C54BDD /* SentryFormatterSwift.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = SentryFormatterSwift.m; sourceTree = "<group>"; };
FA94E68B2E6B92BE00576666 /* SentryClientReport.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SentryClientReport.swift; sourceTree = "<group>"; };
FA94E6B12E6D265500576666 /* SentryEnvelope.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SentryEnvelope.swift; sourceTree = "<group>"; };
FA94E7232E6F32FA00576666 /* SentryEnvelopeItemType.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SentryEnvelopeItemType.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -2541,6 +2547,8 @@
FAEEC04C2E75E55A00E79CA9 /* SentrySerializationSwift.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SentrySerializationSwift.swift; sourceTree = "<group>"; };
FAEFA1292E4FAE1700C431D9 /* SentrySDKSettings.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SentrySDKSettings.swift; sourceTree = "<group>"; };
FAF0F3CA2EA7DD0700E44E9B /* SentryANRTrackerTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SentryANRTrackerTests.swift; sourceTree = "<group>"; };
FAFA35872EF2FD24006B145F /* SentryMXCallStackTree+Parsing.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "SentryMXCallStackTree+Parsing.swift"; sourceTree = "<group>"; };
FAFA358E2EF2FD8C006B145F /* MXSample.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MXSample.swift; sourceTree = "<group>"; };
/* End PBXFileReference section */

/* Begin PBXFrameworksBuildPhase section */
Expand Down Expand Up @@ -2956,6 +2964,8 @@
639889D51EDF10BE00EA7442 /* Helper */ = {
isa = PBXGroup;
children = (
FA914E952ED61AA300C54BDD /* SentryFormatterSwift.h */,
FA914E9C2ED61AB900C54BDD /* SentryFormatterSwift.m */,
FA4FB8252ECB7D27008C9EC3 /* SentryLevel.h */,
63AA76951EB9C1C200D153DE /* SentryDefines.h */,
627E7588299F6FE40085504D /* SentryInternalDefines.h */,
Expand Down Expand Up @@ -5051,6 +5061,8 @@
isa = PBXGroup;
children = (
FA67DCD82DDBD4EA00896B02 /* SentryMXCallStackTree.swift */,
FAFA35872EF2FD24006B145F /* SentryMXCallStackTree+Parsing.swift */,
FAFA358E2EF2FD8C006B145F /* MXSample.swift */,
FA67DCD92DDBD4EA00896B02 /* SentryMXManager.swift */,
);
path = MetricKit;
Expand Down Expand Up @@ -5292,6 +5304,7 @@
FAB359982E05D7E90083D5E3 /* SentryEventSwiftHelper.h in Headers */,
7B31C291277B04A000337126 /* SentryCrashPlatformSpecificDefines.h in Headers */,
D452FC732DDB553100AFF56F /* SentryWatchdogTerminationBreadcrumbProcessor.h in Headers */,
FA914E9B2ED61AA800C54BDD /* SentryFormatterSwift.h in Headers */,
D456B4382D706BFE007068CB /* SentrySpanDataKey.h in Headers */,
7B77BE3527EC8445003C9020 /* SentryDiscardReasonMapper.h in Headers */,
7B610D602512390E00B0B5D9 /* SentrySDK+Private.h in Headers */,
Expand Down Expand Up @@ -5879,6 +5892,7 @@
D48891CC2E98F22A00212823 /* SentryInfoPlistWrapperProvider.swift in Sources */,
F458D1172E186DF20028273E /* SentryScopePersistentStore+Fingerprint.swift in Sources */,
D8CB7417294724CC00A5F964 /* SentryEnvelopeAttachmentHeader.m in Sources */,
FA914E9E2ED61BA800C54BDD /* SentryFormatterSwift.m in Sources */,
D84793262788737D00BE8E99 /* SentryByteCountFormatter.m in Sources */,
FAEFA12F2E4FAE1900C431D9 /* SentrySDKSettings.swift in Sources */,
63AA769E1EB9C57A00D153DE /* SentryError.mm in Sources */,
Expand Down Expand Up @@ -5932,6 +5946,7 @@
7D082B8323C628790029866B /* SentryMeta.m in Sources */,
D8CAC02F2BA0663E00E38F34 /* SentryVideoInfo.swift in Sources */,
FAAB95CD2EA18B2E0030A2DB /* SentryDependencyContainer.swift in Sources */,
FAFA358D2EF2FD2A006B145F /* SentryMXCallStackTree+Parsing.swift in Sources */,
63FE710720DA4C1000CDBAE8 /* SentryCrashStackCursor_SelfThread.m in Sources */,
63FE711120DA4C1000CDBAE8 /* SentryCrashDebug.c in Sources */,
7B883F49253D714C00879E62 /* SentryCrashUUIDConversion.c in Sources */,
Expand Down Expand Up @@ -6026,6 +6041,7 @@
FA67DD0F2DDBD4EA00896B02 /* SentryViewControllerBreadcrumbTracking.swift in Sources */,
FA67DD102DDBD4EA00896B02 /* StringExtensions.swift in Sources */,
FA67DD112DDBD4EA00896B02 /* SentryANRType.swift in Sources */,
FAFA358F2EF2FD8F006B145F /* MXSample.swift in Sources */,
FAAB95D82EA1E23F0030A2DB /* SentryExtraContextProvider.swift in Sources */,
FA67DD122DDBD4EA00896B02 /* Locks.swift in Sources */,
62CB19252E77F8FD00AF5DA2 /* SentryDispatchSourceWrapper.swift in Sources */,
Expand Down
7 changes: 7 additions & 0 deletions Sources/Sentry/SentryFormatterSwift.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#import "SentryFormatter.h"

NSString *
sentry_formatHexAddressUInt64Swift(uint64_t value)
{
return sentry_formatHexAddressUInt64(value);
}
Loading
Loading