Skip to content

Conversation

@Jeffreyhung
Copy link
Member

@Jeffreyhung Jeffreyhung commented Nov 12, 2025

Resolves the following Linear tickets:


[Copy-pasted from Semgrep]
Using variable interpolation $...`` with github context data in a run: step could allow an attacker to inject their own code into the runner. This would allow them to steal secrets and code. github context data can have arbitrary user input and should be treated as untrusted. Instead, use an intermediate environment variable with env: to store the data and use the environment variable in the run: script. Be sure to use double-quotes the environment variable, like this: "$ENVVAR".

Severity: High

References:

semgrep rule

https://docs.github.com/en/actions/learn-github-actions/security-hardening-for-github-actions#understanding-the-risk-of-script-injections

https://securitylab.github.com/research/github-actions-untrusted-input/

#skip-changelog

@philprime
Copy link
Member

Thank you for tackling this issue. It looks to me like some of the issues might actually be resolved by merging #6721 so I would like to wait for that one to be merged first.

@philprime philprime self-assigned this Nov 12, 2025
@Jeffreyhung
Copy link
Member Author

@philprime sounds good! That PR resolved the issues in ready-to-merge workflow, but not the rest, so we will still need this.

@philprime philprime added the ready-to-merge Use this label to trigger all PR workflows label Nov 13, 2025
@philprime philprime merged commit 43f1295 into main Nov 13, 2025
158 of 167 checks passed
@philprime philprime deleted the resolve-shell-injection-vulnerabilities branch November 13, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants