ref: Remove v9 checks for debug image provider#6454
Merged
noahsmartin merged 1 commit intomainfrom Oct 20, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6454 +/- ##
=============================================
+ Coverage 87.023% 87.025% +0.002%
=============================================
Files 450 451 +1
Lines 37806 37751 -55
Branches 17494 17474 -20
=============================================
- Hits 32900 32853 -47
+ Misses 4863 4855 -8
Partials 43 43
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
a67e933 to
910fb79
Compare
910fb79 to
ea8dff7
Compare
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 13bc1aa | 1244.04 ms | 1262.89 ms | 18.85 ms |
| 2a07609 | 1207.79 ms | 1233.77 ms | 25.98 ms |
| 59fc426 | 1240.49 ms | 1256.94 ms | 16.45 ms |
| 8f2120f | 1235.92 ms | 1249.67 ms | 13.75 ms |
| 1a820a1 | 1217.79 ms | 1260.34 ms | 42.55 ms |
| d3e7aa6 | 1226.06 ms | 1248.87 ms | 22.81 ms |
| 9264ee8 | 1233.15 ms | 1250.02 ms | 16.87 ms |
| a4c5ddc | 1239.61 ms | 1266.41 ms | 26.80 ms |
| 92a02b8 | 1220.89 ms | 1249.27 ms | 28.37 ms |
| c122943 | 1210.94 ms | 1233.78 ms | 22.84 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 13bc1aa | 23.75 KiB | 908.40 KiB | 884.65 KiB |
| 2a07609 | 23.75 KiB | 912.78 KiB | 889.03 KiB |
| 59fc426 | 23.75 KiB | 920.64 KiB | 896.89 KiB |
| 8f2120f | 23.75 KiB | 941.78 KiB | 918.03 KiB |
| 1a820a1 | 23.75 KiB | 994.82 KiB | 971.07 KiB |
| d3e7aa6 | 23.75 KiB | 913.16 KiB | 889.41 KiB |
| 9264ee8 | 23.75 KiB | 913.09 KiB | 889.34 KiB |
| a4c5ddc | 23.75 KiB | 977.30 KiB | 953.55 KiB |
| 92a02b8 | 23.75 KiB | 913.17 KiB | 889.42 KiB |
| c122943 | 23.74 KiB | 926.65 KiB | 902.90 KiB |
ea8dff7 to
cd501e4
Compare
philprime
approved these changes
Oct 20, 2025
Member
philprime
left a comment
There was a problem hiding this comment.
LGTM, left one comment to double-check
cd501e4 to
1df3813
Compare
This was referenced Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The V9 migration makes this class internal instead of public, which means it needs to be migrated to Swift to be part of the Swift dependency container. This removes the V9 checks and migrates it to Swift
#skip-changelog
Closes #6455