Use env vars instead of direct interpolation in run commands
#6388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
This resolves potential command injection vulnerabilities that were reported to us.
While not all changes are prone to this issue, I have opted to move all interpolated vars in run commands to new vars to keep it consistent.
Also added ${VAR} curly braces just in places where we visually want to disambiguate, they are not strictly necessary.
💡 Motivation and Context
Relates to MOBILE-1036
💚 How did you test it?
CI should run successfully. Please review carefully, I did not verify if all affected LOC are run when opening a PR.