Skip to content

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 7, 2025

Removes one more v9 check for a codable class. Already added this to changelog in a previous PR that copied it from the V9 changelog.

#skip-changelog

Closes #6380

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.854%. Comparing base (fa9a4bb) to head (254c059).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6379       +/-   ##
=============================================
+ Coverage   86.765%   86.854%   +0.089%     
=============================================
  Files          438       439        +1     
  Lines        37311     37329       +18     
  Branches     17421     17411       -10     
=============================================
+ Hits         32373     32422       +49     
+ Misses        4893      4862       -31     
  Partials        45        45               
Files with missing lines Coverage Δ
...wift/Protocol/Codable/SentryDebugMetaCodable.swift 100.000% <ø> (ø)

... and 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa9a4bb...254c059. Read the comment docs.

Copy link
Contributor

github-actions bot commented Oct 8, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.12 ms 1263.24 ms 39.12 ms
Size 23.75 KiB 989.27 KiB 965.53 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b714cb9 1224.71 ms 1238.04 ms 13.33 ms
d8b2303 1231.53 ms 1249.89 ms 18.35 ms
59fc426 1240.49 ms 1256.94 ms 16.45 ms
cbbc82c 1246.43 ms 1266.13 ms 19.70 ms
7f4bf81 1241.73 ms 1270.66 ms 28.93 ms
8203ac0 1235.59 ms 1256.02 ms 20.43 ms
c6c1cb7 1235.71 ms 1263.80 ms 28.08 ms
7aaa0b6 1230.49 ms 1263.78 ms 33.29 ms
cc7f629 1226.00 ms 1245.51 ms 19.51 ms
c8dd5e4 1217.67 ms 1242.90 ms 25.23 ms

App size

Revision Plain With Sentry Diff
b714cb9 23.75 KiB 858.69 KiB 834.93 KiB
d8b2303 23.75 KiB 908.02 KiB 884.27 KiB
59fc426 23.75 KiB 920.64 KiB 896.89 KiB
cbbc82c 23.75 KiB 995.22 KiB 971.47 KiB
7f4bf81 23.75 KiB 919.70 KiB 895.95 KiB
8203ac0 23.75 KiB 959.44 KiB 935.69 KiB
c6c1cb7 23.75 KiB 928.15 KiB 904.40 KiB
7aaa0b6 23.75 KiB 989.97 KiB 966.23 KiB
cc7f629 23.75 KiB 878.48 KiB 854.73 KiB
c8dd5e4 23.75 KiB 913.48 KiB 889.72 KiB

Previous results on branch: removeV9ChecksCodable

Startup times

Revision Plain With Sentry Diff
d5671ca 1232.93 ms 1256.41 ms 23.47 ms
b887253 1230.82 ms 1268.76 ms 37.93 ms
75a96de 1219.77 ms 1247.24 ms 27.47 ms

App size

Revision Plain With Sentry Diff
d5671ca 23.75 KiB 988.69 KiB 964.94 KiB
b887253 23.75 KiB 986.83 KiB 963.08 KiB
75a96de 23.75 KiB 986.88 KiB 963.13 KiB

@noahsmartin noahsmartin force-pushed the removeV9ChecksCodable branch from 9f14869 to 7587116 Compare October 8, 2025 03:23
@noahsmartin noahsmartin marked this pull request as draft October 8, 2025 03:37
@noahsmartin noahsmartin force-pushed the removeV9ChecksCodable branch 6 times, most recently from 03cf114 to fb46ceb Compare October 8, 2025 21:34
@noahsmartin noahsmartin force-pushed the removeV9ChecksCodable branch from fb46ceb to 254c059 Compare October 8, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Remove debug meta decodable V9 checks

1 participant