Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 3, 2025

#skip-changelog

Closes #6344

@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.229%. Comparing base (78af7a9) to head (acebd16).
⚠️ Report is 11 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6343       +/-   ##
=============================================
- Coverage   87.293%   87.229%   -0.064%     
=============================================
  Files          438       439        +1     
  Lines        37311     37243       -68     
  Branches     17435     17371       -64     
=============================================
- Hits         32570     32487       -83     
- Misses        4696      4710       +14     
- Partials        45        46        +1     
Files with missing lines Coverage Δ
Sources/Sentry/Profiling/SentryLaunchProfiling.m 81.884% <ø> (-6.408%) ⬇️
Sources/Sentry/SentryOptions.m 97.250% <ø> (-0.210%) ⬇️
Sources/Sentry/SentyOptionsInternal.m 99.675% <ø> (-0.009%) ⬇️

... and 35 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78af7a9...acebd16. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1229.29 ms 1263.09 ms 33.79 ms
Size 23.75 KiB 988.03 KiB 964.28 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
162cd7f 1230.59 ms 1256.76 ms 26.16 ms
bc0a04c 1226.83 ms 1255.04 ms 28.21 ms
029a804 1219.65 ms 1241.96 ms 22.30 ms
e4ba9a7 1219.82 ms 1230.89 ms 11.07 ms
1a34ddc 1217.79 ms 1242.17 ms 24.38 ms
9add417 1224.33 ms 1243.06 ms 18.73 ms
f37e3fe 1230.24 ms 1254.51 ms 24.27 ms
d1c4916 1216.66 ms 1244.73 ms 28.08 ms
3cdbc22 1231.63 ms 1251.06 ms 19.43 ms
fd94b0d 1226.50 ms 1258.69 ms 32.19 ms

App size

Revision Plain With Sentry Diff
162cd7f 23.75 KiB 908.39 KiB 884.64 KiB
bc0a04c 23.75 KiB 933.32 KiB 909.57 KiB
029a804 23.75 KiB 928.11 KiB 904.36 KiB
e4ba9a7 23.75 KiB 969.22 KiB 945.47 KiB
1a34ddc 23.75 KiB 919.90 KiB 896.15 KiB
9add417 23.75 KiB 908.40 KiB 884.65 KiB
f37e3fe 23.75 KiB 919.70 KiB 895.95 KiB
d1c4916 23.75 KiB 981.31 KiB 957.56 KiB
3cdbc22 23.75 KiB 928.14 KiB 904.40 KiB
fd94b0d 23.75 KiB 928.88 KiB 905.13 KiB

Previous results on branch: removeEnableTracingFlag

Startup times

Revision Plain With Sentry Diff
39f2422 1229.11 ms 1260.88 ms 31.76 ms
d744e45 1209.00 ms 1249.75 ms 40.75 ms
d56e031 1221.42 ms 1263.49 ms 42.07 ms
d68fff1 1218.85 ms 1248.02 ms 29.17 ms
4673768 1219.50 ms 1248.93 ms 29.43 ms

App size

Revision Plain With Sentry Diff
39f2422 23.75 KiB 989.55 KiB 965.81 KiB
d744e45 23.75 KiB 989.56 KiB 965.82 KiB
d56e031 23.75 KiB 988.19 KiB 964.44 KiB
d68fff1 23.75 KiB 989.72 KiB 965.97 KiB
4673768 23.75 KiB 989.70 KiB 965.96 KiB

@noahsmartin noahsmartin force-pushed the removeEnableTracingFlag branch from b141419 to 2b52610 Compare October 4, 2025 14:38
@noahsmartin noahsmartin force-pushed the removeEnableTracingFlag branch 2 times, most recently from 3868783 to 5ecc901 Compare October 7, 2025 00:21
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin force-pushed the removeEnableTracingFlag branch 2 times, most recently from 59a56be to 28abc78 Compare October 8, 2025 23:01
@noahsmartin noahsmartin force-pushed the removeEnableTracingFlag branch from 28abc78 to acebd16 Compare October 8, 2025 23:54
@noahsmartin noahsmartin merged commit 4267263 into main Oct 9, 2025
244 of 255 checks passed
@noahsmartin noahsmartin deleted the removeEnableTracingFlag branch October 9, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove enable tracing flag from V9

4 participants