-
-
Notifications
You must be signed in to change notification settings - Fork 371
Remove enable tracing flag from V9 #6343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6343 +/- ##
=============================================
- Coverage 87.293% 87.229% -0.064%
=============================================
Files 438 439 +1
Lines 37311 37243 -68
Branches 17435 17371 -64
=============================================
- Hits 32570 32487 -83
- Misses 4696 4710 +14
- Partials 45 46 +1
... and 35 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 162cd7f | 1230.59 ms | 1256.76 ms | 26.16 ms |
| bc0a04c | 1226.83 ms | 1255.04 ms | 28.21 ms |
| 029a804 | 1219.65 ms | 1241.96 ms | 22.30 ms |
| e4ba9a7 | 1219.82 ms | 1230.89 ms | 11.07 ms |
| 1a34ddc | 1217.79 ms | 1242.17 ms | 24.38 ms |
| 9add417 | 1224.33 ms | 1243.06 ms | 18.73 ms |
| f37e3fe | 1230.24 ms | 1254.51 ms | 24.27 ms |
| d1c4916 | 1216.66 ms | 1244.73 ms | 28.08 ms |
| 3cdbc22 | 1231.63 ms | 1251.06 ms | 19.43 ms |
| fd94b0d | 1226.50 ms | 1258.69 ms | 32.19 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 162cd7f | 23.75 KiB | 908.39 KiB | 884.64 KiB |
| bc0a04c | 23.75 KiB | 933.32 KiB | 909.57 KiB |
| 029a804 | 23.75 KiB | 928.11 KiB | 904.36 KiB |
| e4ba9a7 | 23.75 KiB | 969.22 KiB | 945.47 KiB |
| 1a34ddc | 23.75 KiB | 919.90 KiB | 896.15 KiB |
| 9add417 | 23.75 KiB | 908.40 KiB | 884.65 KiB |
| f37e3fe | 23.75 KiB | 919.70 KiB | 895.95 KiB |
| d1c4916 | 23.75 KiB | 981.31 KiB | 957.56 KiB |
| 3cdbc22 | 23.75 KiB | 928.14 KiB | 904.40 KiB |
| fd94b0d | 23.75 KiB | 928.88 KiB | 905.13 KiB |
Previous results on branch: removeEnableTracingFlag
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 39f2422 | 1229.11 ms | 1260.88 ms | 31.76 ms |
| d744e45 | 1209.00 ms | 1249.75 ms | 40.75 ms |
| d56e031 | 1221.42 ms | 1263.49 ms | 42.07 ms |
| d68fff1 | 1218.85 ms | 1248.02 ms | 29.17 ms |
| 4673768 | 1219.50 ms | 1248.93 ms | 29.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 39f2422 | 23.75 KiB | 989.55 KiB | 965.81 KiB |
| d744e45 | 23.75 KiB | 989.56 KiB | 965.82 KiB |
| d56e031 | 23.75 KiB | 988.19 KiB | 964.44 KiB |
| d68fff1 | 23.75 KiB | 989.72 KiB | 965.97 KiB |
| 4673768 | 23.75 KiB | 989.70 KiB | 965.96 KiB |
b141419 to
2b52610
Compare
3868783 to
5ecc901
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
59a56be to
28abc78
Compare
28abc78 to
acebd16
Compare
#skip-changelog
Closes #6344