Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Sep 30, 2025

Convert SentryDateUtil to Swift which blocks: #6285

Closes #6308

#skip-changelog

@linear
Copy link

linear bot commented Sep 30, 2025

cursor[bot]

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Sep 30, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
3938 2 3936 52
View the top 3 failed test(s) by shortest run time
SentryTests.SentryANRTrackerV1Tests::testMultipleListeners
Stack Traces | 0s run time
.../Integrations/ANR/SentryANRTrackerV1Tests.swift:78 - Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "ANR Detection".
iOS_Swift_UITests.LaunchUITests::testCaptureException
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/LaunchUITests.swift:43 - Failed to Error Domain=com.apple.dt.XCTest.XCTFuture Code=1000 "Timed out while evaluating UI query." UserInfo={NSLocalizedDescription=Timed out while evaluating UI query.}: Timed out while evaluating UI query.
iOS_Swift_UITests.LaunchUITests::testCheckSlowAndFrozenFrames
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/LaunchUITests.swift:66 - Failed to Error Domain=com.apple.dt.XCTest.XCTFuture Code=1000 "Timed out while evaluating UI query." UserInfo={NSLocalizedDescription=Timed out while evaluating UI query.}: Timed out while evaluating UI query.
iOS_Swift_UITests.LaunchUITests::testUiClickTransaction
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/LaunchUITests.swift:34 - Failed to Error Domain=com.apple.dt.XCTest.XCTFuture Code=1000 "Timed out while evaluating UI query." UserInfo={NSLocalizedDescription=Timed out while evaluating UI query.}: Timed out while evaluating UI query.
iOS_Swift_UITests.UIEventBreadcrumbTests::testExtractInfoFromView
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/UITestHelpers.swift:5 - Failed to get matching snapshots: Error getting main window kAXErrorServerNotFound
iOS_Swift_UITests.ViewLifecycleUITests::testViewLifecycle_callingDismissWithViewWillDisappear_shouldNotCrashSDK
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/ViewLifecycleUITests.swift:89 - Failed to Error Domain=com.apple.dt.XCTest.XCTFuture Code=1000 "Timed out while evaluating UI query." UserInfo={NSLocalizedDescription=Timed out while evaluating UI query.}: Timed out while evaluating UI query.
View the full list of 1 ❄️ flaky test(s)
SentryTests.SentrySDKInternalTests::testResumeAndPauseAppHangTracking

Flake rate in main: 14.00% (Passed 43 times, Failed 7 times)

Stack Traces | 0s run time
.../Tests/SentryTests/SentrySDKInternalTests.swift:633 - XCTAssertEqual failed: ("1") is not equal to ("0") - The SDK should capture an AppHang after resuming the tracking, but it didn't.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.90 ms 1241.51 ms 26.61 ms
Size 23.75 KiB 995.83 KiB 972.08 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e0424b9 1204.23 ms 1241.08 ms 36.85 ms
795dd39 1216.88 ms 1245.47 ms 28.59 ms
856fffe 1232.69 ms 1245.80 ms 13.10 ms
ae7be93 1236.24 ms 1258.18 ms 21.94 ms
9080e6c 1221.17 ms 1247.87 ms 26.71 ms
ea5a59b 1222.87 ms 1253.47 ms 30.60 ms
2b02431 1229.63 ms 1248.98 ms 19.35 ms
5cbd333 1219.93 ms 1241.76 ms 21.83 ms
d05d866 1211.78 ms 1230.96 ms 19.18 ms
7f2f69c 1237.61 ms 1266.96 ms 29.35 ms

App size

Revision Plain With Sentry Diff
e0424b9 23.74 KiB 874.07 KiB 850.33 KiB
795dd39 23.75 KiB 908.16 KiB 884.41 KiB
856fffe 23.75 KiB 975.18 KiB 951.44 KiB
ae7be93 23.75 KiB 879.24 KiB 855.49 KiB
9080e6c 23.75 KiB 926.80 KiB 903.05 KiB
ea5a59b 23.75 KiB 874.46 KiB 850.71 KiB
2b02431 23.75 KiB 850.73 KiB 826.98 KiB
5cbd333 23.74 KiB 969.77 KiB 946.02 KiB
d05d866 23.75 KiB 878.60 KiB 854.85 KiB
7f2f69c 23.75 KiB 913.38 KiB 889.63 KiB

Previous results on branch: itay/cocoa-701-convert-sentryratelimits-to-swift_date_util

Startup times

Revision Plain With Sentry Diff
9727f02 1235.02 ms 1262.92 ms 27.90 ms
5f0ca9b 1229.82 ms 1255.02 ms 25.20 ms

App size

Revision Plain With Sentry Diff
9727f02 23.75 KiB 995.83 KiB 972.08 KiB
5f0ca9b 23.75 KiB 995.99 KiB 972.24 KiB

cursor[bot]

This comment was marked as outdated.

@itaybre itaybre enabled auto-merge (squash) September 30, 2025 22:06
@itaybre itaybre merged commit c8420eb into main Sep 30, 2025
268 of 284 checks passed
@itaybre itaybre deleted the itay/cocoa-701-convert-sentryratelimits-to-swift_date_util branch September 30, 2025 22:18
philprime pushed a commit that referenced this pull request Oct 10, 2025
* ref: Convert `SentryDateUtil` to Swift

* Use Int64

* Go back to use Int since has the same behavior than long on ObjC

* Fix static func
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Convert SentryDateUtil to Swift

3 participants