-
-
Notifications
You must be signed in to change notification settings - Fork 372
ref: Convert SentryDateUtil to Swift
#6307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
itaybre
merged 4 commits into
main
from
itay/cocoa-701-convert-sentryratelimits-to-swift_date_util
Sep 30, 2025
Merged
ref: Convert SentryDateUtil to Swift
#6307
itaybre
merged 4 commits into
main
from
itay/cocoa-701-convert-sentryratelimits-to-swift_date_util
Sep 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 2 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e0424b9 | 1204.23 ms | 1241.08 ms | 36.85 ms |
| 795dd39 | 1216.88 ms | 1245.47 ms | 28.59 ms |
| 856fffe | 1232.69 ms | 1245.80 ms | 13.10 ms |
| ae7be93 | 1236.24 ms | 1258.18 ms | 21.94 ms |
| 9080e6c | 1221.17 ms | 1247.87 ms | 26.71 ms |
| ea5a59b | 1222.87 ms | 1253.47 ms | 30.60 ms |
| 2b02431 | 1229.63 ms | 1248.98 ms | 19.35 ms |
| 5cbd333 | 1219.93 ms | 1241.76 ms | 21.83 ms |
| d05d866 | 1211.78 ms | 1230.96 ms | 19.18 ms |
| 7f2f69c | 1237.61 ms | 1266.96 ms | 29.35 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e0424b9 | 23.74 KiB | 874.07 KiB | 850.33 KiB |
| 795dd39 | 23.75 KiB | 908.16 KiB | 884.41 KiB |
| 856fffe | 23.75 KiB | 975.18 KiB | 951.44 KiB |
| ae7be93 | 23.75 KiB | 879.24 KiB | 855.49 KiB |
| 9080e6c | 23.75 KiB | 926.80 KiB | 903.05 KiB |
| ea5a59b | 23.75 KiB | 874.46 KiB | 850.71 KiB |
| 2b02431 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| 5cbd333 | 23.74 KiB | 969.77 KiB | 946.02 KiB |
| d05d866 | 23.75 KiB | 878.60 KiB | 854.85 KiB |
| 7f2f69c | 23.75 KiB | 913.38 KiB | 889.63 KiB |
Previous results on branch: itay/cocoa-701-convert-sentryratelimits-to-swift_date_util
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9727f02 | 1235.02 ms | 1262.92 ms | 27.90 ms |
| 5f0ca9b | 1229.82 ms | 1255.02 ms | 25.20 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9727f02 | 23.75 KiB | 995.83 KiB | 972.08 KiB |
| 5f0ca9b | 23.75 KiB | 995.99 KiB | 972.24 KiB |
noahsmartin
approved these changes
Sep 30, 2025
philprime
pushed a commit
that referenced
this pull request
Oct 10, 2025
* ref: Convert `SentryDateUtil` to Swift * Use Int64 * Go back to use Int since has the same behavior than long on ObjC * Fix static func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
SentryDateUtilto Swift which blocks: #6285Closes #6308
#skip-changelog