-
-
Notifications
You must be signed in to change notification settings - Fork 366
ref: SentryPerformanceTracker in Swift #6271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f471d43
to
099b0ae
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6271 +/- ##
=============================================
- Coverage 86.772% 7.607% -79.165%
=============================================
Files 441 408 -33
Lines 37285 35610 -1675
Branches 17345 14001 -3344
=============================================
- Hits 32353 2709 -29644
- Misses 4888 32889 +28001
+ Partials 44 12 -32
... and 421 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
a1a45b2
to
1ddca4b
Compare
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e3767a1 | 1224.20 ms | 1257.16 ms | 32.96 ms |
b115f82 | 1212.96 ms | 1251.92 ms | 38.96 ms |
438caec | 1230.02 ms | 1250.00 ms | 19.98 ms |
7d23639 | 1237.93 ms | 1243.04 ms | 5.11 ms |
e64d3d4 | 1241.90 ms | 1260.10 ms | 18.20 ms |
5200f5b | 1231.73 ms | 1254.35 ms | 22.62 ms |
701acf0 | 1230.24 ms | 1255.60 ms | 25.36 ms |
2675d3c | 1218.94 ms | 1239.36 ms | 20.42 ms |
80538ca | 1216.70 ms | 1253.92 ms | 37.22 ms |
884b224 | 1233.41 ms | 1259.50 ms | 26.09 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e3767a1 | 23.75 KiB | 913.14 KiB | 889.39 KiB |
b115f82 | 23.75 KiB | 989.04 KiB | 965.30 KiB |
438caec | 23.74 KiB | 913.14 KiB | 889.40 KiB |
7d23639 | 23.75 KiB | 891.01 KiB | 867.26 KiB |
e64d3d4 | 23.75 KiB | 855.37 KiB | 831.62 KiB |
5200f5b | 23.75 KiB | 933.33 KiB | 909.58 KiB |
701acf0 | 23.75 KiB | 987.96 KiB | 964.21 KiB |
2675d3c | 23.75 KiB | 928.16 KiB | 904.41 KiB |
80538ca | 23.75 KiB | 989.99 KiB | 966.24 KiB |
884b224 | 23.75 KiB | 879.60 KiB | 855.86 KiB |
Previous results on branch: performanceTrackerSwift
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2dcf808 | 1217.09 ms | 1249.37 ms | 32.28 ms |
4e0213e | 1230.06 ms | 1258.98 ms | 28.92 ms |
360791c | 1227.61 ms | 1268.07 ms | 40.46 ms |
38cbfc6 | 1223.93 ms | 1257.56 ms | 33.62 ms |
47c237d | 1222.31 ms | 1241.70 ms | 19.40 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2dcf808 | 23.75 KiB | 997.36 KiB | 973.62 KiB |
4e0213e | 23.75 KiB | 997.91 KiB | 974.16 KiB |
360791c | 23.75 KiB | 997.38 KiB | 973.63 KiB |
38cbfc6 | 23.75 KiB | 997.91 KiB | 974.16 KiB |
47c237d | 23.75 KiB | 996.03 KiB | 972.28 KiB |
061c240
to
dce84ae
Compare
5044a43
to
a8097fc
Compare
edd1c08
to
5b926e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a small comment
5b926e0
to
e7f8d78
Compare
e7f8d78
to
3c66029
Compare
This depends on #6417
This PR will close https://linear.app/getsentry/issue/COCOA-554/convert-sentryperformancetracker-to-swift
#skip-changelog