Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Sep 19, 2025

#skip-changelog

Closes #6224

@codecov
Copy link

codecov bot commented Sep 19, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3969 1 3968 17
View the top 3 failed test(s) by shortest run time
SentryCrashBinaryImageCacheTests::testRemoveImageAddAgain
Stack Traces | 0s run time
.../SentryTests/SentryCrash/SentryCrashBinaryImageCacheTests.m:310 - ((counter) equal to (expected)) failed: ("6") is not equal to ("5")
iOS_SwiftUI_UITests.LaunchUITests::testTransactionSpan
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift:18 - Failed to get matching snapshots: Timed out while evaluating UI query.
iOS_Swift_UITests.UserFeedbackUITests::testAddingScreenshots
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/UserFeedbackUITests.swift:670 - XCTUnwrap failed: expected non-nil value of type "String"
iOS_Swift_UITests.ViewLifecycleUITests::testViewLifecycle_callingDismissWithViewWillAppear_shouldNotCrashSDK
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/ViewLifecycleUITests.swift:60 - Failed to tap "view-lifecycle-test" Button: Timed out while evaluating UI query.
View the full list of 1 ❄️ flaky tests
SentryTests.SentrySDKInternalTests::testResumeAndPauseAppHangTracking

Flake rate in main: 14.00% (Passed 43 times, Failed 7 times)

Stack Traces | 0s run time
.../Tests/SentryTests/SentrySDKInternalTests.swift:632 - XCTAssertEqual failed: ("1") is not equal to ("0") - The SDK should capture an AppHang after resuming the tracking, but it didn't.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1238.84 ms 1261.29 ms 22.45 ms
Size 23.74 KiB 978.22 KiB 954.48 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8e3a42f 1222.90 ms 1245.67 ms 22.77 ms
c03a8d8 1234.77 ms 1259.19 ms 24.42 ms
67e8e3e 1238.80 ms 1266.02 ms 27.22 ms
62f8d2a 1226.24 ms 1249.92 ms 23.67 ms
bbe6658 1221.00 ms 1248.51 ms 27.51 ms
d06a4db 1233.20 ms 1243.18 ms 9.98 ms
0529194 1237.23 ms 1254.67 ms 17.44 ms
8fd192f 1202.10 ms 1220.19 ms 18.09 ms
25f2d2c 1232.02 ms 1242.78 ms 10.76 ms
870b081 1226.77 ms 1246.33 ms 19.56 ms

App size

Revision Plain With Sentry Diff
8e3a42f 23.75 KiB 880.06 KiB 856.31 KiB
c03a8d8 23.75 KiB 928.15 KiB 904.40 KiB
67e8e3e 23.75 KiB 919.88 KiB 896.13 KiB
62f8d2a 23.75 KiB 926.80 KiB 903.05 KiB
bbe6658 23.75 KiB 908.02 KiB 884.27 KiB
d06a4db 23.75 KiB 913.18 KiB 889.43 KiB
0529194 23.74 KiB 891.02 KiB 867.28 KiB
8fd192f 23.74 KiB 872.75 KiB 849.01 KiB
25f2d2c 23.75 KiB 866.69 KiB 842.94 KiB
870b081 23.75 KiB 974.89 KiB 951.15 KiB

Previous results on branch: convertSentryThreadWrapperSwift

Startup times

Revision Plain With Sentry Diff
0dace30 1221.45 ms 1246.04 ms 24.59 ms

App size

Revision Plain With Sentry Diff
0dace30 23.74 KiB 977.30 KiB 953.56 KiB

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin force-pushed the convertSentryThreadWrapperSwift branch from 47cd002 to 356bee5 Compare September 22, 2025 14:49
@noahsmartin noahsmartin merged commit aff3b66 into main Sep 22, 2025
204 of 214 checks passed
@noahsmartin noahsmartin deleted the convertSentryThreadWrapperSwift branch September 22, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Convert SentryThreadWrapper to Swift

3 participants