Skip to content

meta: Add comment explaining why the crash was moved to onAppear #5899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

meta: Add comment explaining why the crash was moved to onAppear #5899

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c13be80
meta: Add comment explaining why the crash was moved to onAppear
itaybre Aug 12, 2025
b8b27ef
Improve message
itaybre Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions TestSamples/SwiftUICrashTest/SwiftUICrashTest/SwiftUICrashTestApp.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ struct SwiftUICrashTestApp: App {
WindowGroup {
ContentView()
.onAppear {
// Moved the crash from init to onAppear to ensure the app is fully loaded before crashing.
// This prevents test flakiness on CI that occurred when the crash happened during the app launch.
let userDefaultsKey = "crash-on-launch"
if UserDefaults.standard.bool(forKey: userDefaultsKey) {
NSLog("SwiftUICrashTestApp - will crash")
Expand Down
Loading