Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Aug 8, 2025

We have some variance on what code is executed on our tests.
Because of this, the lines covered may change a little bit, with some builds changing by 0.017%.
I believe this is within as margin of error and can be safely ingored

#skip-changelog

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.636%. Comparing base (7cc23cf) to head (aaf3b30).
⚠️ Report is 14 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5859       +/-   ##
=============================================
- Coverage   86.663%   86.636%   -0.028%     
=============================================
  Files          423       423               
  Lines        36405     36405               
  Branches     17227     17229        +2     
=============================================
- Hits         31550     31540       -10     
- Misses        4809      4817        +8     
- Partials        46        48        +2     

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc23cf...aaf3b30. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I almost always ignore the report when it fails.

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you, I believe this will also fix the red checks on main

@itaybre
Copy link
Contributor Author

itaybre commented Aug 11, 2025

LGTM, thank you, I believe this will also fix the red checks on main

That's the idea, we can play with the number to find our ideal value.

LGTM, I almost always ignore the report when it fails.

Same for me, but I would like to be able to see when it is relevant

@itaybre itaybre merged commit 4bf98bf into main Aug 11, 2025
24 of 25 checks passed
@itaybre itaybre deleted the feature/codecov_threshhold branch August 11, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants