-
-
Notifications
You must be signed in to change notification settings - Fork 372
fix(react-native): Fixes React Native closure compilation issue #5816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5816 +/- ##
=============================================
+ Coverage 86.623% 86.641% +0.017%
=============================================
Files 423 423
Lines 36347 36343 -4
Branches 17096 17091 -5
=============================================
+ Hits 31485 31488 +3
+ Misses 4815 4810 -5
+ Partials 47 45 -2
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4e3915a | 1230.02 ms | 1258.90 ms | 28.88 ms |
| c2982e7 | 1223.92 ms | 1242.86 ms | 18.94 ms |
| 736bcfb | 1229.86 ms | 1249.59 ms | 19.73 ms |
| 2a07609 | 1207.79 ms | 1233.77 ms | 25.98 ms |
| 9add417 | 1224.33 ms | 1243.06 ms | 18.73 ms |
| 2a7868a | 1226.54 ms | 1256.92 ms | 30.37 ms |
| d38165b | 1211.41 ms | 1242.49 ms | 31.08 ms |
| 42cfd79 | 1222.13 ms | 1244.23 ms | 22.10 ms |
| aa98fe8 | 1227.69 ms | 1253.18 ms | 25.50 ms |
| b714cb9 | 1224.71 ms | 1238.04 ms | 13.33 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4e3915a | 23.75 KiB | 858.69 KiB | 834.94 KiB |
| c2982e7 | 23.75 KiB | 911.62 KiB | 887.87 KiB |
| 736bcfb | 23.74 KiB | 891.02 KiB | 867.28 KiB |
| 2a07609 | 23.75 KiB | 912.78 KiB | 889.03 KiB |
| 9add417 | 23.75 KiB | 908.40 KiB | 884.65 KiB |
| 2a7868a | 23.75 KiB | 880.20 KiB | 856.45 KiB |
| d38165b | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| 42cfd79 | 23.75 KiB | 880.20 KiB | 856.45 KiB |
| aa98fe8 | 23.75 KiB | 891.01 KiB | 867.26 KiB |
| b714cb9 | 23.75 KiB | 858.69 KiB | 834.93 KiB |
…ue (getsentry#5816)" This reverts commit be6a4ee.
…ue (getsentry#5816)" This reverts commit be6a4ee.
📜 Description
Adds
selfin closures to fix older react native compilation issue💡 Motivation and Context
See getsentry/sentry-react-native#5038 (comment)
Fixes errors like the following in RN
0.65.3that uses more strict compilation rulesThis should unblock 8.54.0 RN bump along with the other changes in getsentry/sentry-react-native#5038
💚 How did you test it?
CI
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.#skip-changelog