Skip to content

Conversation

@philprime
Copy link
Member

Moves the utility macro introduced in #5737 from the public SentryDefines.h to the internal SentryInternalDefines.h, as it does not need to be publicly exposed.

#skip-changelog

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.657%. Comparing base (b5ef4c0) to head (b764465).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5759       +/-   ##
=============================================
+ Coverage   86.538%   86.657%   +0.119%     
=============================================
  Files          424       423        -1     
  Lines        36303     36327       +24     
  Branches     15457     17095     +1638     
=============================================
+ Hits         31416     31480       +64     
+ Misses        4844      4800       -44     
- Partials        43        47        +4     
Files with missing lines Coverage Δ
Sources/Sentry/SentryArray.m 100.000% <ø> (ø)
Sources/Sentry/SentryNSDataUtils.m 97.619% <ø> (ø)
Sources/Sentry/SentyOptionsInternal.m 99.680% <ø> (ø)
Sources/Sentry/include/SentryInternalDefines.h 61.538% <100.000%> (+1.538%) ⬆️

... and 23 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ef4c0...b764465. Read the comment docs.

@philprime philprime added the Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks. label Jul 30, 2025
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.88 ms 1257.54 ms 25.66 ms
Size 23.75 KiB 912.61 KiB 888.86 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d3f650a 1225.45 ms 1241.86 ms 16.41 ms
e64d3d4 1241.90 ms 1260.10 ms 18.20 ms
0759f32 1237.10 ms 1257.35 ms 20.25 ms
aa96485 1215.37 ms 1234.04 ms 18.67 ms
2bddb03 1214.11 ms 1246.78 ms 32.67 ms
fc0757d 1231.83 ms 1248.98 ms 17.15 ms
99104c9 1224.84 ms 1247.08 ms 22.24 ms
f8029e2 1245.16 ms 1261.32 ms 16.16 ms
8ad303c 1220.02 ms 1231.79 ms 11.77 ms
079bcc8 1217.88 ms 1234.88 ms 17.00 ms

App size

Revision Plain With Sentry Diff
d3f650a 23.75 KiB 902.48 KiB 878.73 KiB
e64d3d4 23.75 KiB 855.37 KiB 831.62 KiB
0759f32 23.75 KiB 880.20 KiB 856.46 KiB
aa96485 23.75 KiB 874.46 KiB 850.71 KiB
2bddb03 23.75 KiB 891.01 KiB 867.26 KiB
fc0757d 23.75 KiB 850.73 KiB 826.98 KiB
99104c9 23.75 KiB 894.83 KiB 871.09 KiB
f8029e2 23.75 KiB 893.72 KiB 869.97 KiB
8ad303c 23.75 KiB 879.24 KiB 855.49 KiB
079bcc8 23.74 KiB 874.07 KiB 850.33 KiB

@philprime philprime merged commit b57ee62 into main Jul 30, 2025
129 of 132 checks passed
@philprime philprime deleted the philprime/fix-sentry-defines branch July 30, 2025 14:28
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants