-
-
Notifications
You must be signed in to change notification settings - Fork 372
fix: remove internal macro SENTRY_UNWRAP_NULLABLE from public header #5759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5759 +/- ##
=============================================
+ Coverage 86.538% 86.657% +0.119%
=============================================
Files 424 423 -1
Lines 36303 36327 +24
Branches 15457 17095 +1638
=============================================
+ Hits 31416 31480 +64
+ Misses 4844 4800 -44
- Partials 43 47 +4
... and 23 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d3f650a | 1225.45 ms | 1241.86 ms | 16.41 ms |
| e64d3d4 | 1241.90 ms | 1260.10 ms | 18.20 ms |
| 0759f32 | 1237.10 ms | 1257.35 ms | 20.25 ms |
| aa96485 | 1215.37 ms | 1234.04 ms | 18.67 ms |
| 2bddb03 | 1214.11 ms | 1246.78 ms | 32.67 ms |
| fc0757d | 1231.83 ms | 1248.98 ms | 17.15 ms |
| 99104c9 | 1224.84 ms | 1247.08 ms | 22.24 ms |
| f8029e2 | 1245.16 ms | 1261.32 ms | 16.16 ms |
| 8ad303c | 1220.02 ms | 1231.79 ms | 11.77 ms |
| 079bcc8 | 1217.88 ms | 1234.88 ms | 17.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d3f650a | 23.75 KiB | 902.48 KiB | 878.73 KiB |
| e64d3d4 | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| 0759f32 | 23.75 KiB | 880.20 KiB | 856.46 KiB |
| aa96485 | 23.75 KiB | 874.46 KiB | 850.71 KiB |
| 2bddb03 | 23.75 KiB | 891.01 KiB | 867.26 KiB |
| fc0757d | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| 99104c9 | 23.75 KiB | 894.83 KiB | 871.09 KiB |
| f8029e2 | 23.75 KiB | 893.72 KiB | 869.97 KiB |
| 8ad303c | 23.75 KiB | 879.24 KiB | 855.49 KiB |
| 079bcc8 | 23.74 KiB | 874.07 KiB | 850.33 KiB |
… header (getsentry#5759)" This reverts commit b57ee62.
… header (getsentry#5759)" This reverts commit b57ee62.
Moves the utility macro introduced in #5737 from the public
SentryDefines.hto the internalSentryInternalDefines.h, as it does not need to be publicly exposed.#skip-changelog