test: Fix potential deadlock in TestLogOutput #5617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test testLoggingFromMultipleThreads lead to deadlocks. This is fixed now by using a NSLock instead of a DispatchQueue. This PR also makes the logsToConsole immutable and adds more tests.
philipphofmann
requested review from
armcknight,
itaybre,
noahsmartin and
philprime
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5617 +/- ##
=============================================
- Coverage 86.495% 86.495% -0.001%
=============================================
Files 415 415
Lines 35271 35269 -2
Branches 15278 15284 +6
=============================================
- Hits 30508 30506 -2
- Misses 4722 4723 +1
+ Partials 41 40 -1 see 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
itaybre
approved these changes
Jul 11, 2025
philipsawyerdd
added a commit
to justin-doordash/sentry-cocoa
that referenced
this pull request
Sep 25, 2025
This reverts commit 2a7868a.
philipsawyerdd
added a commit
to justin-doordash/sentry-cocoa
that referenced
this pull request
Sep 25, 2025
This reverts commit 2a7868a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test testLoggingFromMultipleThreads lead to deadlocks. This is fixed now by using a NSLock instead of a DispatchQueue. This PR also makes the logsToConsole immutable and adds more tests.