test: Remove dep container usage in HTTPTransport #5552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a couple of DependencyContainer usages and use the date provider of the fixture instead, because we want to limit the usage of the DependencyContainer as much as we can during testing cause it it global state.
philipphofmann
requested review from
NicoHinderling,
armcknight,
itaybre,
noahsmartin,
philprime and
trevor-e
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5552 +/- ##
=============================================
- Coverage 86.211% 86.118% -0.093%
=============================================
Files 407 407
Lines 35079 35069 -10
Branches 15241 15016 -225
=============================================
- Hits 30242 30201 -41
- Misses 4794 4825 +31
Partials 43 43 see 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
noahsmartin
approved these changes
Jul 2, 2025
philipsawyerdd
added a commit
to justin-doordash/sentry-cocoa
that referenced
this pull request
Sep 25, 2025
philipsawyerdd
added a commit
to justin-doordash/sentry-cocoa
that referenced
this pull request
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a couple of DependencyContainer usages and use the date provider of the fixture instead, because we want to limit the usage of the DependencyContainer as much as we can during testing, cause it is global state.
Came up while looking at #5421.
#skip-changelog