Skip to content

Conversation

@noahsmartin
Copy link
Contributor

Now that SentryDispatchQueueWrapper a few more of these are unblocked to be public and we can get a bit closer to not requiring the app extension API only flag

#skip-changelog

@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.256%. Comparing base (b0e13a7) to head (2cfe016).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5498       +/-   ##
=============================================
- Coverage   86.276%   86.256%   -0.021%     
=============================================
  Files          402       402               
  Lines        34912     34910        -2     
  Branches     15155     15154        -1     
=============================================
- Hits         30121     30112        -9     
- Misses        4743      4754       +11     
+ Partials        48        44        -4     
Files with missing lines Coverage Δ
.../Integrations/ANR/SentryANRTrackerV2Delegate.swift 100.000% <100.000%> (ø)
...es/Swift/Core/Integrations/ANR/SentryANRType.swift 100.000% <100.000%> (ø)
...tions/FramesTracking/SentryFramesDelayResult.swift 100.000% <ø> (ø)
Sources/Swift/Core/MetricKit/SentryMXManager.swift 100.000% <ø> (ø)
.../Tools/ViewCapture/SentryDefaultViewRenderer.swift 100.000% <100.000%> (ø)
...ore/Tools/ViewCapture/SentryRedactViewHelper.swift 72.000% <100.000%> (ø)
...ore/Tools/ViewCapture/SentryViewPhotographer.swift 73.913% <100.000%> (ø)
.../Core/Tools/ViewCapture/SentryViewRendererV2.swift 92.857% <100.000%> (ø)
...rces/Swift/Helper/SentryDispatchQueueWrapper.swift 100.000% <100.000%> (ø)
...ssionReplay/Preview/SentryMaskingPreviewView.swift 86.274% <ø> (ø)
... and 10 more

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e13a7...2cfe016. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@armcknight
Copy link
Member

Just adding this to keep things connected: #5371

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.98 ms 1248.85 ms 21.87 ms
Size 23.75 KiB 867.15 KiB 843.41 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4e3915a 1230.02 ms 1258.90 ms 28.88 ms
d38165b 1211.41 ms 1242.49 ms 31.08 ms
b13e93a 1236.24 ms 1247.33 ms 11.08 ms
35c962f 1207.61 ms 1235.90 ms 28.29 ms
5cfc768 1220.74 ms 1245.06 ms 24.32 ms
b714cb9 1224.71 ms 1238.04 ms 13.33 ms
8ea5293 1242.70 ms 1262.25 ms 19.55 ms
b0e13a7 1227.71 ms 1245.88 ms 18.16 ms
2b02431 1229.63 ms 1248.98 ms 19.35 ms
f92cfa9 1228.45 ms 1251.33 ms 22.88 ms

App size

Revision Plain With Sentry Diff
4e3915a 23.75 KiB 858.69 KiB 834.94 KiB
d38165b 23.75 KiB 855.37 KiB 831.62 KiB
b13e93a 23.75 KiB 855.37 KiB 831.62 KiB
35c962f 23.75 KiB 854.77 KiB 831.02 KiB
5cfc768 23.75 KiB 850.73 KiB 826.98 KiB
b714cb9 23.75 KiB 858.69 KiB 834.93 KiB
8ea5293 23.75 KiB 852.24 KiB 828.49 KiB
b0e13a7 23.75 KiB 860.98 KiB 837.23 KiB
2b02431 23.75 KiB 850.73 KiB 826.98 KiB
f92cfa9 23.75 KiB 855.38 KiB 831.62 KiB

@noahsmartin noahsmartin merged commit 701b301 into main Jun 26, 2025
129 of 133 checks passed
@noahsmartin noahsmartin deleted the addMoreSPIPublic branch June 26, 2025 02:36
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants