-
-
Notifications
You must be signed in to change notification settings - Fork 372
Add more SPI #5498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more SPI #5498
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5498 +/- ##
=============================================
- Coverage 86.276% 86.256% -0.021%
=============================================
Files 402 402
Lines 34912 34910 -2
Branches 15155 15154 -1
=============================================
- Hits 30121 30112 -9
- Misses 4743 4754 +11
+ Partials 48 44 -4
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Just adding this to keep things connected: #5371 |
e6df2bc to
2cfe016
Compare
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4e3915a | 1230.02 ms | 1258.90 ms | 28.88 ms |
| d38165b | 1211.41 ms | 1242.49 ms | 31.08 ms |
| b13e93a | 1236.24 ms | 1247.33 ms | 11.08 ms |
| 35c962f | 1207.61 ms | 1235.90 ms | 28.29 ms |
| 5cfc768 | 1220.74 ms | 1245.06 ms | 24.32 ms |
| b714cb9 | 1224.71 ms | 1238.04 ms | 13.33 ms |
| 8ea5293 | 1242.70 ms | 1262.25 ms | 19.55 ms |
| b0e13a7 | 1227.71 ms | 1245.88 ms | 18.16 ms |
| 2b02431 | 1229.63 ms | 1248.98 ms | 19.35 ms |
| f92cfa9 | 1228.45 ms | 1251.33 ms | 22.88 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4e3915a | 23.75 KiB | 858.69 KiB | 834.94 KiB |
| d38165b | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| b13e93a | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| 35c962f | 23.75 KiB | 854.77 KiB | 831.02 KiB |
| 5cfc768 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| b714cb9 | 23.75 KiB | 858.69 KiB | 834.93 KiB |
| 8ea5293 | 23.75 KiB | 852.24 KiB | 828.49 KiB |
| b0e13a7 | 23.75 KiB | 860.98 KiB | 837.23 KiB |
| 2b02431 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| f92cfa9 | 23.75 KiB | 855.38 KiB | 831.62 KiB |
This reverts commit 701b301.
This reverts commit 701b301.
Now that SentryDispatchQueueWrapper a few more of these are unblocked to be public and we can get a bit closer to not requiring the app extension API only flag
#skip-changelog