Skip to content

Conversation

noahsmartin
Copy link
Contributor

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

#skip-changelog

@noahsmartin noahsmartin force-pushed the convertURLRequestToSwift branch 2 times, most recently from b5a48b9 to 3224a90 Compare June 21, 2025 01:56
Copy link

codecov bot commented Jun 21, 2025

Codecov Report

❌ Patch coverage is 97.10145% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.102%. Comparing base (95cfd20) to head (3d3b119).
⚠️ Report is 396 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Swift/Tools/SentryURLRequestFactory.swift 95.454% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5451       +/-   ##
=============================================
- Coverage   86.221%   86.102%   -0.119%     
=============================================
  Files          399       398        -1     
  Lines        34647     34510      -137     
  Branches     14983     14877      -106     
=============================================
- Hits         29873     29714      -159     
- Misses        4726      4755       +29     
+ Partials        48        41        -7     
Files with missing lines Coverage Δ
Sources/Sentry/SentryHttpTransport.m 98.154% <100.000%> (-0.007%) ⬇️
Sources/Sentry/SentrySpotlightTransport.m 78.571% <100.000%> (-0.739%) ⬇️
Sources/Sentry/SentryTransportFactory.m 100.000% <ø> (ø)
Sources/Swift/Tools/SentryURLRequestBuilder.swift 100.000% <100.000%> (ø)
Sources/Swift/Tools/SentryURLRequestFactory.swift 95.454% <95.454%> (ø)

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95cfd20...3d3b119. Read the comment docs.

Copy link
Contributor

github-actions bot commented Jun 21, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1209.57 ms 1231.88 ms 22.31 ms
Size 23.75 KiB 849.08 KiB 825.34 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c5232ea 1226.06 ms 1246.57 ms 20.50 ms
464117d 1240.46 ms 1252.91 ms 12.45 ms
94e1968 1230.22 ms 1253.33 ms 23.11 ms
3ea21f5 1250.80 ms 1258.88 ms 8.08 ms
b1783fd 1216.67 ms 1238.75 ms 22.08 ms
794f87f 1225.78 ms 1243.46 ms 17.68 ms
17afc4b 1228.94 ms 1251.10 ms 22.16 ms
6e31b7c 1230.80 ms 1246.29 ms 15.49 ms
25e00aa 1236.98 ms 1250.98 ms 14.00 ms
4c00f8c 1231.62 ms 1237.76 ms 6.14 ms

App size

Revision Plain With Sentry Diff
c5232ea 22.85 KiB 413.98 KiB 391.13 KiB
464117d 21.58 KiB 705.40 KiB 683.82 KiB
94e1968 21.58 KiB 614.74 KiB 593.15 KiB
3ea21f5 22.84 KiB 402.63 KiB 379.78 KiB
b1783fd 22.31 KiB 818.59 KiB 796.28 KiB
794f87f 20.76 KiB 401.37 KiB 380.61 KiB
17afc4b 20.76 KiB 436.25 KiB 415.49 KiB
6e31b7c 21.58 KiB 614.65 KiB 593.07 KiB
25e00aa 23.76 KiB 821.43 KiB 797.67 KiB
4c00f8c 20.76 KiB 419.62 KiB 398.86 KiB

Previous results on branch: convertURLRequestToSwift

Startup times

Revision Plain With Sentry Diff
d06ea1f 1217.63 ms 1235.61 ms 17.98 ms

App size

Revision Plain With Sentry Diff
d06ea1f 23.75 KiB 849.07 KiB 825.33 KiB

@noahsmartin noahsmartin force-pushed the convertURLRequestToSwift branch from 3224a90 to 57e9a71 Compare June 21, 2025 02:46
@noahsmartin noahsmartin force-pushed the convertURLRequestToSwift branch from 57e9a71 to 3d3b119 Compare June 21, 2025 02:54
@noahsmartin noahsmartin changed the title Convert url request to Swift [WIP] Convert url request to Swift Jun 21, 2025
@philprime
Copy link
Member

I am not sure right now if you want us to review this, as the title indicates WIP but the PR is marked as ready-for-review. Please clarify.

@noahsmartin noahsmartin marked this pull request as draft June 23, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants