-
-
Notifications
You must be signed in to change notification settings - Fork 372
Add thread info helper #5331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thread info helper #5331
Conversation
db5ab22 to
6a99d24
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5331 +/- ##
=============================================
+ Coverage 92.903% 92.983% +0.079%
=============================================
Files 691 702 +11
Lines 86707 87876 +1169
Branches 31235 31533 +298
=============================================
+ Hits 80554 81710 +1156
- Misses 6054 6064 +10
- Partials 99 102 +3
... and 38 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8cf5bca | 1231.33 ms | 1237.81 ms | 6.48 ms |
| de033da | 1206.55 ms | 1217.08 ms | 10.53 ms |
| beb7ff7 | 1211.40 ms | 1224.12 ms | 12.73 ms |
| 5949b9e | 1235.45 ms | 1260.21 ms | 24.76 ms |
| 4bca912 | 1252.42 ms | 1260.06 ms | 7.64 ms |
| 313b1d9 | 1240.18 ms | 1258.44 ms | 18.26 ms |
| 5783680 | 1223.63 ms | 1243.60 ms | 19.97 ms |
| 2124551 | 1201.23 ms | 1225.34 ms | 24.11 ms |
| b9b0f0a | 1220.20 ms | 1229.27 ms | 9.06 ms |
| c0ff306 | 1218.92 ms | 1240.64 ms | 21.72 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8cf5bca | 21.58 KiB | 671.30 KiB | 649.72 KiB |
| de033da | 21.58 KiB | 418.15 KiB | 396.57 KiB |
| beb7ff7 | 21.58 KiB | 669.46 KiB | 647.87 KiB |
| 5949b9e | 22.30 KiB | 832.29 KiB | 809.98 KiB |
| 4bca912 | 22.85 KiB | 411.14 KiB | 388.29 KiB |
| 313b1d9 | 22.85 KiB | 414.11 KiB | 391.26 KiB |
| 5783680 | 21.58 KiB | 714.18 KiB | 692.60 KiB |
| 2124551 | 22.85 KiB | 411.69 KiB | 388.84 KiB |
| b9b0f0a | 20.76 KiB | 434.94 KiB | 414.18 KiB |
| c0ff306 | 20.76 KiB | 434.65 KiB | 413.89 KiB |
6a99d24 to
b22a64c
Compare
philprime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments, feel free to proceed.
Moves some swift imports out of ObjC++ by defining a helper that does not import Swift to perform the C++ code
#skip-changelog