Skip to content

Conversation

@krystofwoldrich
Copy link
Contributor

@krystofwoldrich krystofwoldrich commented Feb 26, 2025

#skip-changelog

Although GH docs say ios 18.2 is present on macos-14 runners (https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md#installed-sdks), it doesn't seem to be the case by default https://github.com/getsentry/sentry-cocoa/actions/runs/13554352815/job/37885252787?pr=4909

So I bumped the job to macos-15.

This should fix the warning about building without iOS 18 SDK.
@krystofwoldrich
Copy link
Contributor Author

The upload fails on No ipa or pkg file given.

@krystofwoldrich krystofwoldrich marked this pull request as draft February 26, 2025 22:22
@philipphofmann
Copy link
Member

philipphofmann commented Feb 27, 2025

I bumped fastlane with #4913 and sentry-fastlane with #4914. Maybe it fixes the problem.

@codecov
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.407%. Comparing base (89acc84) to head (3f342a9).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4909       +/-   ##
=============================================
- Coverage   92.408%   92.407%   -0.002%     
=============================================
  Files          660       660               
  Lines        77732     77732               
  Branches     28154     28151        -3     
=============================================
- Hits         71831     71830        -1     
  Misses        5804      5804               
- Partials        97        98        +1     

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89acc84...3f342a9. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.06 ms 1248.54 ms 18.48 ms
Size 22.30 KiB 819.10 KiB 796.80 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
26af50b 1223.78 ms 1245.93 ms 22.16 ms
f1d1166 1237.54 ms 1256.06 ms 18.52 ms
7207796 1223.80 ms 1235.92 ms 12.11 ms
dacf894 1232.32 ms 1236.34 ms 4.02 ms
adcc7d8 1225.90 ms 1245.08 ms 19.18 ms
736495a 1245.16 ms 1254.42 ms 9.26 ms
421cd69 1226.96 ms 1250.18 ms 23.23 ms
542727d 1227.96 ms 1246.88 ms 18.92 ms
b07998b 1216.88 ms 1244.18 ms 27.31 ms
98752f3 1226.18 ms 1251.38 ms 25.20 ms

App size

Revision Plain With Sentry Diff
26af50b 21.58 KiB 542.38 KiB 520.80 KiB
f1d1166 21.58 KiB 630.74 KiB 609.16 KiB
7207796 21.58 KiB 418.14 KiB 396.56 KiB
dacf894 20.76 KiB 426.34 KiB 405.58 KiB
adcc7d8 20.76 KiB 426.15 KiB 405.39 KiB
736495a 20.76 KiB 435.22 KiB 414.46 KiB
421cd69 22.31 KiB 780.75 KiB 758.43 KiB
542727d 21.58 KiB 571.85 KiB 550.26 KiB
b07998b 22.30 KiB 749.77 KiB 727.47 KiB
98752f3 20.76 KiB 435.09 KiB 414.33 KiB

Previous results on branch: krystofwoldrich-patch-2

Startup times

Revision Plain With Sentry Diff
a662fe7 1226.20 ms 1248.59 ms 22.40 ms

App size

Revision Plain With Sentry Diff
a662fe7 22.30 KiB 819.11 KiB 796.81 KiB

@philipphofmann
Copy link
Member

There is a known issue with Xcode 16; fastlane/fastlane#22276.

@philipphofmann philipphofmann marked this pull request as ready for review March 4, 2025 08:19
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann merged commit 0cb9644 into main Mar 4, 2025
23 checks passed
@philipphofmann philipphofmann deleted the krystofwoldrich-patch-2 branch March 4, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants