chore: add first pre-commit hook to check tool versions #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armcknight
requested review from
philipphofmann and
brustolin
as code owners
philipphofmann
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the installed version of clang-format and swiftlint and fail fast from the pre-commit run if they don't match what's in the homebrew lockfile. This approach could be extended to e.g. Gemfile.lock as well if desired.
We previously wanted to go the other way on this in #3739. But I still ran into local issues with mismatched lint/format rules dirtying unmodified files, so that didn't fix the root issue. I think this is the better solution than just not tracking the lockfiles.
#skip-changelog