-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename session replay redact
options and APIs to mask
#4373
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if the SR team is on board with this.
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1bf8571 | 1250.96 ms | 1255.36 ms | 4.40 ms |
2ccbd03 | 1225.13 ms | 1247.51 ms | 22.39 ms |
d011484 | 1220.86 ms | 1237.18 ms | 16.33 ms |
6001822 | 1220.82 ms | 1245.02 ms | 24.20 ms |
3723833 | 1205.22 ms | 1216.94 ms | 11.71 ms |
ff09c7e | 1240.94 ms | 1262.66 ms | 21.72 ms |
b9d59f7 | 1250.71 ms | 1257.78 ms | 7.06 ms |
94d8eb3 | 1234.02 ms | 1249.63 ms | 15.60 ms |
e773cad | 1219.86 ms | 1238.26 ms | 18.40 ms |
90d17d3 | 1261.18 ms | 1278.18 ms | 17.00 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1bf8571 | 20.76 KiB | 437.12 KiB | 416.36 KiB |
2ccbd03 | 21.58 KiB | 546.20 KiB | 524.62 KiB |
d011484 | 21.58 KiB | 616.14 KiB | 594.56 KiB |
6001822 | 22.85 KiB | 410.98 KiB | 388.13 KiB |
3723833 | 21.58 KiB | 424.34 KiB | 402.76 KiB |
ff09c7e | 20.76 KiB | 427.76 KiB | 407.00 KiB |
b9d59f7 | 22.85 KiB | 405.77 KiB | 382.93 KiB |
94d8eb3 | 21.58 KiB | 417.86 KiB | 396.28 KiB |
e773cad | 21.58 KiB | 681.75 KiB | 660.17 KiB |
90d17d3 | 20.76 KiB | 432.17 KiB | 411.41 KiB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4373 +/- ##
=============================================
+ Coverage 91.450% 91.461% +0.010%
=============================================
Files 629 629
Lines 50625 50619 -6
Branches 18346 18338 -8
=============================================
Hits 46297 46297
+ Misses 4235 4228 -7
- Partials 93 94 +1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -62,11 +62,11 @@ class UIRedactBuilder { | |||
init(options: SentryRedactOptions) { | |||
var redactClasses = [AnyClass]() | |||
|
|||
if options.redactAllText { | |||
if options.maskAllText { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redactAllText
is still present in comments & method docs
📜 Description
Renaming SR
redact
tomask
and ignoreto
unmask`📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps