Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix the versioning to support app release with Beta versions #4368

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

brustolin
Copy link
Contributor

@brustolin brustolin commented Sep 25, 2024

📜 Description

Xcode does not allow an app to be publish with a framework that does not follow the versioning standard.

For more information see #4359

#skip-changelog

@brustolin brustolin self-assigned this Sep 25, 2024
@brustolin brustolin linked an issue Sep 25, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.454%. Comparing base (3138592) to head (1a88567).
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4368       +/-   ##
=============================================
- Coverage   91.535%   91.454%   -0.082%     
=============================================
  Files          628       631        +3     
  Lines        50706     50786       +80     
  Branches     18396     18408       +12     
=============================================
+ Hits         46414     46446       +32     
- Misses        4199      4246       +47     
- Partials        93        94        +1     
Files with missing lines Coverage Δ
Tests/SentryTests/SentryTests.m 100.000% <ø> (ø)

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3138592...1a88567. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tests/SentryTests/SentryTests.m Show resolved Hide resolved
@philipphofmann
Copy link
Member

Doesn't this deserve an entry in the changelog?

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.94 ms 1240.82 ms 13.88 ms
Size 21.58 KiB 737.54 KiB 715.96 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d3630c3 1229.78 ms 1241.94 ms 12.16 ms
9fa25c2 1211.88 ms 1228.36 ms 16.48 ms
e71cf92 1201.69 ms 1226.52 ms 24.83 ms
b2f82fa 1237.78 ms 1256.02 ms 18.24 ms
84fdd22 1229.73 ms 1243.43 ms 13.69 ms
9cc7e7c 1231.84 ms 1245.24 ms 13.41 ms
6001822 1234.49 ms 1265.20 ms 30.71 ms
e19cca3 1211.69 ms 1231.04 ms 19.35 ms
804fd04 1224.46 ms 1243.77 ms 19.31 ms
60d6cec 1257.14 ms 1273.92 ms 16.78 ms

App size

Revision Plain With Sentry Diff
d3630c3 22.84 KiB 403.19 KiB 380.34 KiB
9fa25c2 22.85 KiB 407.44 KiB 384.59 KiB
e71cf92 20.76 KiB 419.85 KiB 399.10 KiB
b2f82fa 20.76 KiB 419.62 KiB 398.86 KiB
84fdd22 21.58 KiB 683.50 KiB 661.92 KiB
9cc7e7c 22.84 KiB 403.14 KiB 380.29 KiB
6001822 22.85 KiB 410.98 KiB 388.13 KiB
e19cca3 21.58 KiB 669.74 KiB 648.16 KiB
804fd04 21.58 KiB 695.04 KiB 673.46 KiB
60d6cec 22.84 KiB 403.51 KiB 380.67 KiB

@brustolin brustolin merged commit 4eea4d1 into main Oct 2, 2024
64 of 65 checks passed
@brustolin brustolin deleted the fix/beta-in-plist branch October 2, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix beta release bundle info
2 participants