Skip to content

Conversation

@philipphofmann
Copy link
Member

Make triggering a non-fully blocking app hang where some frames are rendered, but the UI still seems stuck to the user more realistic by continuously blocking the main thread for 0.5 seconds and then quickly rendering a few frames and then blocking it again.

#skip-changelog

Make triggering a non-fully blocking app hang where some frames are
rendered, but the UI still seems stuck to the user more realistic by
continuously blocking the main thread for 0.5 seconds and then quickly
rendering a few frames and then blocking it again.
@codecov
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.530%. Comparing base (5f6f658) to head (03cb29e).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4265       +/-   ##
=============================================
+ Coverage   91.510%   91.530%   +0.020%     
=============================================
  Files          612       612               
  Lines        49470     49471        +1     
  Branches     17902     17920       +18     
=============================================
+ Hits         45270     45281       +11     
+ Misses        4107      4098        -9     
+ Partials        93        92        -1     

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f6f658...03cb29e. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.29 ms 1235.36 ms 13.08 ms
Size 21.58 KiB 699.25 KiB 677.67 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e998fd0 1241.49 ms 1262.63 ms 21.14 ms
b15521e 1221.69 ms 1237.51 ms 15.82 ms
ef5821b 1253.18 ms 1265.46 ms 12.28 ms
533c68f 1236.54 ms 1256.68 ms 20.14 ms
4ae9b7a 1223.94 ms 1243.90 ms 19.96 ms
5230990 1222.86 ms 1243.59 ms 20.73 ms
bd2afa6 1241.37 ms 1246.20 ms 4.83 ms
189b629 1211.16 ms 1224.30 ms 13.14 ms
3f1be0f 1208.12 ms 1225.72 ms 17.60 ms
3de9971 1224.38 ms 1245.33 ms 20.95 ms

App size

Revision Plain With Sentry Diff
e998fd0 21.58 KiB 414.59 KiB 393.01 KiB
b15521e 21.58 KiB 573.17 KiB 551.59 KiB
ef5821b 21.58 KiB 414.96 KiB 393.37 KiB
533c68f 21.58 KiB 630.28 KiB 608.70 KiB
4ae9b7a 21.58 KiB 632.04 KiB 610.46 KiB
5230990 21.58 KiB 682.39 KiB 660.81 KiB
bd2afa6 20.76 KiB 420.55 KiB 399.79 KiB
189b629 20.76 KiB 399.69 KiB 378.93 KiB
3f1be0f 20.76 KiB 414.44 KiB 393.69 KiB
3de9971 21.58 KiB 574.17 KiB 552.59 KiB

Previous results on branch: test/improve-non-fully-blocking-anr

Startup times

Revision Plain With Sentry Diff
8a32165 1238.82 ms 1252.88 ms 14.06 ms

App size

Revision Plain With Sentry Diff
8a32165 21.58 KiB 699.25 KiB 677.67 KiB

@philipphofmann philipphofmann merged commit d8cc6ae into main Aug 9, 2024
@philipphofmann philipphofmann deleted the test/improve-non-fully-blocking-anr branch August 9, 2024 04:40
@philipphofmann philipphofmann self-assigned this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants