-
-
Notifications
You must be signed in to change notification settings - Fork 372
test: remove Nimble #4120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove Nimble #4120
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4120 +/- ##
=============================================
+ Coverage 91.339% 91.340% +0.001%
=============================================
Files 610 610
Lines 48414 48422 +8
Branches 17317 17351 +34
=============================================
+ Hits 44221 44229 +8
+ Misses 4101 4100 -1
- Partials 92 93 +1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
brustolin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
|
Thanks a lot @armcknight 🥇 |
The test guidelines in contributing.md still mention to use Nimble, but we removed Nimble with GH-4120.
The test guidelines in contributing.md still mention to use Nimble, but we removed Nimble with GH-4120.
This was added as a team experiment, but recently we decided not to move forward with it.
Lately, it has been causing me pain on every branch switch. Because SPM still has so many problems in Xcode, I would have to manually re-resolve packages to be able to run tests again. No network connection? Well, now you can't resolve the packages, so local testing ¯\(ツ)/¯ This is the only thing we use SPM for in our SDK project, so will be a marked improvement to jettison.
There are several other reasons we decided not to move forward with Nimble, but I'm not going to repeat them here at this time.
Contains a couple other small fixes, like converting some more IUOs to
try XCTunwrap,XCTAssertTrue->XCTAssert,XCTAssertEqual(..., nil)->XCTAssertNiletc#skip-changelog