Skip to content

Conversation

@armcknight
Copy link
Member

@armcknight armcknight commented Jun 25, 2024

This was added as a team experiment, but recently we decided not to move forward with it.

Lately, it has been causing me pain on every branch switch. Because SPM still has so many problems in Xcode, I would have to manually re-resolve packages to be able to run tests again. No network connection? Well, now you can't resolve the packages, so local testing ¯\(ツ)/¯ This is the only thing we use SPM for in our SDK project, so will be a marked improvement to jettison.

There are several other reasons we decided not to move forward with Nimble, but I'm not going to repeat them here at this time.

Contains a couple other small fixes, like converting some more IUOs to try XCTunwrap, XCTAssertTrue->XCTAssert, XCTAssertEqual(..., nil)->XCTAssertNil etc

#skip-changelog

@codecov
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 99.76581% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.340%. Comparing base (5be7a7c) to head (a5b349c).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4120       +/-   ##
=============================================
+ Coverage   91.339%   91.340%   +0.001%     
=============================================
  Files          610       610               
  Lines        48414     48422        +8     
  Branches     17317     17351       +34     
=============================================
+ Hits         44221     44229        +8     
+ Misses        4101      4100        -1     
- Partials        92        93        +1     
Files Coverage Δ
...entryTests/Categories/SentryNSDataUtilsTests.swift 100.000% <100.000%> (ø)
...entryTests/Helper/SentryAppStateManagerTests.swift 100.000% <100.000%> (ø)
Tests/SentryTests/Helper/SentryAppStateTests.swift 100.000% <100.000%> (ø)
Tests/SentryTests/Helper/SentryDateUtilTests.swift 100.000% <100.000%> (ø)
...yTests/Helper/SentryDependencyContainerTests.swift 100.000% <100.000%> (ø)
...sts/Helper/SentryEnabledFeaturesBuilderTests.swift 100.000% <100.000%> (ø)
...Tests/Helper/SentryExtraContextProviderTests.swift 100.000% <100.000%> (ø)
...ts/SentryTests/Helper/SentryFileManagerTests.swift 99.119% <100.000%> (ø)
.../SentryTests/Helper/SentrySerializationTests.swift 98.009% <100.000%> (ø)
...ests/SentryTests/Helper/SentryTimeSwiftTests.swift 100.000% <100.000%> (ø)
... and 54 more

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be7a7c...a5b349c. Read the comment docs.

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@armcknight armcknight merged commit 0d37a82 into main Jun 26, 2024
@armcknight armcknight deleted the armcknight/test/remove-nimble branch June 26, 2024 18:24
@philipphofmann
Copy link
Member

Thanks a lot @armcknight 🥇

@philipphofmann philipphofmann mentioned this pull request Oct 11, 2024
philipphofmann added a commit that referenced this pull request Oct 11, 2024
The test guidelines in contributing.md still mention to use Nimble, but
we removed Nimble with GH-4120.
philipphofmann added a commit that referenced this pull request Oct 14, 2024
The test guidelines in contributing.md still mention to use Nimble, but
we removed Nimble with GH-4120.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants