Skip to content

Conversation

@brustolin
Copy link
Contributor

Adding a new framework to iOS-Swift sample broke TestFlight upload because of some bundle identifier collision.

We don't really need this in the samples right now, we have a unit test for it.

In the future if the necessity changes we try to figure it out the identifier collision.

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1260.04 ms 1268.76 ms 8.72 ms
Size 22.85 KiB 413.98 KiB 391.13 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b9d59f7 1250.71 ms 1257.78 ms 7.06 ms
3f1be0f 1208.12 ms 1225.72 ms 17.60 ms
3277f18 1229.29 ms 1248.92 ms 19.63 ms
289c0b8 1245.63 ms 1253.76 ms 8.13 ms
e324230 1225.84 ms 1250.40 ms 24.57 ms
6e342ac 1216.02 ms 1232.88 ms 16.86 ms
4d6f273 1195.63 ms 1232.22 ms 36.59 ms
83d84d7 1244.92 ms 1253.34 ms 8.42 ms
326b7eb 1231.06 ms 1243.56 ms 12.50 ms
2ce582e 1238.98 ms 1259.66 ms 20.68 ms

App size

Revision Plain With Sentry Diff
b9d59f7 22.85 KiB 405.77 KiB 382.93 KiB
3f1be0f 20.76 KiB 414.44 KiB 393.69 KiB
3277f18 22.84 KiB 402.88 KiB 380.03 KiB
289c0b8 22.85 KiB 407.67 KiB 384.82 KiB
e324230 22.85 KiB 408.87 KiB 386.02 KiB
6e342ac 20.76 KiB 436.66 KiB 415.90 KiB
4d6f273 20.76 KiB 426.93 KiB 406.17 KiB
83d84d7 22.84 KiB 402.56 KiB 379.72 KiB
326b7eb 20.76 KiB 432.31 KiB 411.55 KiB
2ce582e 22.85 KiB 410.97 KiB 388.12 KiB

@codecov
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #3459 (62e4a4b) into main (8b39743) will decrease coverage by 0.075%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3459       +/-   ##
=============================================
- Coverage   89.020%   88.946%   -0.075%     
=============================================
  Files          525       525               
  Lines        56652     56480      -172     
  Branches     20395     20089      -306     
=============================================
- Hits         50432     50237      -195     
- Misses        5304      5321       +17     
- Partials       916       922        +6     

see 75 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b39743...62e4a4b. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brustolin brustolin merged commit 556c407 into main Nov 29, 2023
@brustolin brustolin deleted the fix/testflight-upload branch November 29, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants